chore: ignore maintainLockFilesWeekly preset#4346
Open
kim-tsao wants to merge 1 commit intoredhat-developer:mainfrom
Open
chore: ignore maintainLockFilesWeekly preset#4346kim-tsao wants to merge 1 commit intoredhat-developer:mainfrom
kim-tsao wants to merge 1 commit intoredhat-developer:mainfrom
Conversation
Signed-off-by: Kim Tsao <ktsao@redhat.com>
|
Contributor
|
This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days. |
Contributor
|
@kim-tsao Are we sure we want to disable this? I see no issues with updating transitive dependencies, packages should already provide a range of versions they are compatible with, so keeping the lockfile fresh allows us to catch regressions early on. Either way, PRs will need to pass CI, so I would not consider this an issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Please explain the changes you made here.
This preset was added to the Renovate config:best-practices preset recently. We want to ignore it because refreshing the lock file (deleting/recreating) can cause breakage if newer dependencies are incompatible with the plugins
Which issue(s) does this PR fix
https://issues.redhat.com/browse/RHIDP-12428
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer