Skip to content

fix(i18n): dynamic plugin menu items not getting translated#4348

Open
ciiay wants to merge 1 commit intoredhat-developer:mainfrom
ciiay:fix-dynamic-plugin-menu-item-translation
Open

fix(i18n): dynamic plugin menu items not getting translated#4348
ciiay wants to merge 1 commit intoredhat-developer:mainfrom
ciiay:fix-dynamic-plugin-menu-item-translation

Conversation

@ciiay
Copy link
Member

@ciiay ciiay commented Mar 3, 2026

Description

This PR fix the dynamic plugin menu item label not being translated issue.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Before:
image

After:
image

Signed-off-by: Yi Cai <yicai@redhat.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 3, 2026

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

Image was built and published successfully. It is available at:

Copy link
Member

@lokanandaprabhu lokanandaprabhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ciiay , I tested this on cluster but I am not able to see some plugin translations are working, ex Bulk import

image
image

i18n-tranalting menu items

Copy link
Contributor

@HusneShabbir HusneShabbir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to Prabhu's findings.

Also, why is the "Adoption Insights" menu item only being translated for selective locales? Shouldn't it be translated across all of them?

Screen.Recording.2026-03-06.at.12.04.57.PM.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants