Fusetools2 1203 adding tuts thru ENV variable #644
Conversation
|
Moving to an environment variable approach, we should be able to do something like: |
|
Turned out we had to move the environment variable declaration to the cheEditor, but that was the trick! See https://issues.redhat.com/browse/FUSETOOLS2-1203?focusedCommentId=16447082&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16447082 for details |
bfitzpat
changed the title
bfitzpat
force-pushed
the
FUSETOOLS2-1203-adding-tuts-thru-preference
branch
from
d4f2c35 to
f74cb1c
Compare
| await registerEmbeddedTutorials(context, 'Writing Your First Didact Tutorial', './demos/markdown/tutorial/tutorial.didact.md'); | ||
| } | ||
|
|
||
| // append any additional tutorials if we have them |
There was a problem hiding this comment.
the comment is only repeating the name of the method. it does not provide more information. It can be removed to simplify teh code and ease maintenance
There was a problem hiding this comment.
Though you and I disagree on this point, I feel that comments do not clutter the code in this instance and will leave the comment as is. Thank you.
Signed-off-by: Brian Fitzpatrick <[email protected]>
- add test - update to use environment variable - adjusting env variable name - fix test - cleanup Signed-off-by: Brian Fitzpatrick <[email protected]>
Signed-off-by: Brian Fitzpatrick <[email protected]>
Signed-off-by: Brian Fitzpatrick <[email protected]>
bfitzpat
force-pushed
the
FUSETOOLS2-1203-adding-tuts-thru-preference
branch
from
666aa15 to
fe587d7
Compare
|
Addressed your code feedback @apupier. Thank you. |
2 participants
Spun this change out of #551 (the OpenShift Quick Start PoC)
For additional details see https://issues.redhat.com/browse/FUSETOOLS2-1203