Add support for SnippetTextEdit in code actions #3730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hopehadfield
force-pushed
the
3686-linked-proposals
branch
2 times, most recently
from
a95f695 to
00abea2
Compare
hopehadfield
force-pushed
the
3686-linked-proposals
branch
from
866d26a to
8e6007c
Compare
rgrunber
reviewed
Aug 16, 2024
rgrunber
approved these changes
Aug 19, 2024
Member
rgrunber
left a comment
rgrunber
left a comment
There was a problem hiding this comment.
The client-side code here looks good, and is ready to be merged once the LS side is in.
hopehadfield
force-pushed
the
3686-linked-proposals
branch
from
3437c83 to
a8d96b9
Compare
hopehadfield
force-pushed
the
3686-linked-proposals
branch
from
a8d96b9 to
ea02c98
Compare
Member
|
Random fact learned : |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3686
Requires eclipse-jdtls/eclipse.jdt.ls#3229