Avoid notifying of failures for workspace builds. #4032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Notifications of failure aren't shown for project builds - Also standardizes based on approach of other extensions that use similar functionality in their UI elements Signed-off-by: Roland Grunberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to make it easier for users to manually compile their projects (incrementally) quicker and the notification popup can make that a bit annoying. This one :
As an example,
Java: Rebuild Projectsdoesn't show a notifications if there is a failure to build so I really don't thinkJava: Force Java Compilationshould either. Also some of the UI elements at microsoft/vscode-java-dependency#878 , which call thejava.workspace.compilecommand don't notify of any compilation errors. I think it should be enough to show the various error markers.@testforstephen , @jdneo let me know your thoughts on this.