Skip to content

Move to vscode-languageclient 8.0.2 for Qute LS #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 26, 2023
Merged

Move to vscode-languageclient 8.0.2 for Qute LS #506

merged 1 commit into from
Jan 26, 2023

Conversation

angelozerr
Copy link
Contributor

@angelozerr angelozerr commented May 19, 2022 •
edited
Loading

Move to vscode-languageclient 8.0.2 for Qute LS

Fixes #505

Signed-off-by: azerr [email protected]

@angelozerr
Copy link
Contributor Author

angelozerr commented May 19, 2022 •
edited
Loading

This PR requires redhat-developer/quarkus-ls#645

@angelozerr angelozerr marked this pull request as ready for review May 19, 2022 23:46
This was referenced May 19, 2022
Merged
Closed
@rgrunber
Copy link
Member

We should also move vscode-microprofile to vscode-languageclient 8.0.1. Currently it seems to sit at 7.0.0

@angelozerr
Copy link
Contributor Author

We should also move vscode-microprofile to vscode-languageclient 8.0.1. Currently it seems to sit at 7.0.0

yes sure, but this PR is for Qute support. vscode-microprofile is for Quarkus support (application.properties, java support).

We can have different version of vscode-languageclient per extension). I agree with you we need to update vscode-microprofile but it is not a blocker issue for this PR.

@angelozerr
Copy link
Contributor Author

The feature which it is important to test it in this PR is the inlay hint support.

@rgrunber
Copy link
Member

We should hold off on this until we get some clarification on redhat-developer/vscode-java#2377 (comment) . Seems to me like it would not work in Theia.

@datho7561 datho7561 self-requested a review January 23, 2023 20:23
@angelozerr angelozerr force-pushed the vscode-languageclient_8.0.1 branch 4 times, most recently from 6762600 to d299c0e Compare January 26, 2023 15:04
@angelozerr angelozerr changed the title Move to vscode-languageclient 8.0.1 for Qute LS Move to vscode-languageclient 8.0.2 for Qute LS Jan 26, 2023
datho7561
datho7561 requested changes Jan 26, 2023
View reviewed changes
@angelozerr angelozerr force-pushed the vscode-languageclient_8.0.1 branch from d299c0e to 21b0887 Compare January 26, 2023 16:42
datho7561
datho7561 approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks, Angelo!

@datho7561 datho7561 merged commit 0feaa2f into redhat-developer:master Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datho7561 datho7561 datho7561 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move to vscode-languageclient 8.0.1 for Qute LS
3 participants
@angelozerr @rgrunber @datho7561