Support http.noProxy #1134
Open
Support http.noProxy #1134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a check before proxying a request to fetch JSONSchema content, to ensure the request URI does not match the domains specified in the
http.noProxysetting.What issues does this PR fix or reference?
Related to the error described in #694, but not necessarily a complete fix for all circumstances reported by participants.
Is it tested? How?
Added unit tests for the new helper method.
Tested e2e by building and installing from source on a machine behind a ZScaler proxy, then confirming schemas hosted at URLs matching my
NO_PROXYenvironment variable were no longer failing to load. Schemas hosted at proxied URLs also continue to load.