Skip to content

Allow .editorconfig for prettier #1153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joedevivo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow .editorconfig for prettier #1153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/languageservice/services/yamlFormatter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ export class YAMLFormatter {
const prettierOptions: Options = {
parser: 'yaml',
plugins: [yamlPlugin, estreePlugin],
editorConfig: options.editorConfig,
Copy link
Contributor

@datho7561 datho7561 Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this works (I've tested manually in VS Code and it doesn't seem to work). I don't see editorConfig as a parameter in the documentation. To get it to work, you'll need to fetch the config for the file using https://prettier.io/docs/api#prettierresolveconfigfileurlorpath--options, then use the result from that as the config in the call to format instead of the prettierOptions defined here. (or, somehow handle merging the fetched prettier/editorconfig with what the language server has been told).


// --- FormattingOptions ---
tabWidth: (options.tabWidth as number) || options.tabSize,
Expand Down
1 change: 1 addition & 0 deletions src/languageservice/yamlLanguageService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ export interface SchemaConfiguration {
}

export interface CustomFormatterOptions {
editorConfig?: boolean;
singleQuote?: boolean;
bracketSpacing?: boolean;
trailingComma?: boolean;
Expand Down