Skip to content

Comments

MCM: fix auto-detection of vLLM binary cache#168

Merged
fulvius31 merged 1 commit intoredhat-et:mainfrom
fulvius31:some-refactoring
Feb 23, 2026
Merged

MCM: fix auto-detection of vLLM binary cache#168
fulvius31 merged 1 commit intoredhat-et:mainfrom
fulvius31:some-refactoring

Conversation

@fulvius31
Copy link
Collaborator

has_artifact_compile_range_with_triton() only checked for a triton/
subdirectory, which cannot exist when the artifact is a packed binary
file. Recognize binary artifact_compile_range
* files as valid vLLM
cache indicators so detect_cache_mode() returns 'vllm' instead of
falling through to 'triton'.

Also:

  • sync requirements.txt with pyproject.toml (typer[all], structlog)
  • silence pylint R0903 on Pydantic data models
  • disable pylint import-error for declared but not-installed deps

@fulvius31 fulvius31 requested a review from Copilot February 23, 2026 17:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes auto-detection of vLLM binary cache by updating the cache detection logic to recognize binary artifact files in addition to directory-based artifacts. The detection function previously only checked for triton/ subdirectories, causing binary artifacts to be misidentified as triton caches.

Changes:

  • Updated _has_artifact_compile_range_with_triton() to detect both binary artifact files and unpacked artifact directories
  • Synchronized requirements.txt with pyproject.toml for typer and structlog dependencies
  • Added pylint configuration to suppress warnings for Pydantic models and import errors

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
mcm/requirements.txt Synced dependency versions with pyproject.toml, pinned vllm version
mcm/pyproject.toml Removed triton dependency, pinned vllm version, added pylint configuration
mcm/model_cache_manager/utils/utils.py Fixed cache detection to recognize binary artifact files
mcm/model_cache_manager/tests/utils/test_cache_mode_detection.py Added test case for binary artifact cache detection
mcm/model_cache_manager/data/kernel_validator.py Added pylint disable comments for Pydantic model classes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  _has_artifact_compile_range_with_triton() only checked for a triton/
  subdirectory, which cannot exist when the artifact is a packed binary
  file. Recognize binary artifact_compile_range_* files as valid vLLM
  cache indicators so detect_cache_mode() returns 'vllm' instead of
  falling through to 'triton'.

  Also:
  - sync requirements.txt with pyproject.toml (typer[all], structlog)
  - silence pylint R0903 on Pydantic data models
  - disable pylint import-error for declared but not-installed deps

Signed-off-by: Alessandro Sangiorgi <asangior@redhat.com>
@fulvius31
Copy link
Collaborator Author

cc @maryamtahhan

@fulvius31 fulvius31 merged commit d824e71 into redhat-et:main Feb 23, 2026
4 checks passed
maryamtahhan pushed a commit to maryamtahhan/MCU that referenced this pull request Feb 25, 2026
_has_artifact_compile_range_with_triton() only checked for a triton/
  subdirectory, which cannot exist when the artifact is a packed binary
  file. Recognize binary artifact_compile_range_* files as valid vLLM
  cache indicators so detect_cache_mode() returns 'vllm' instead of
  falling through to 'triton'.

  Also:
  - sync requirements.txt with pyproject.toml (typer[all], structlog)
  - silence pylint R0903 on Pydantic data models
  - disable pylint import-error for declared but not-installed deps

Signed-off-by: Alessandro Sangiorgi <asangior@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants