MCM: fix auto-detection of vLLM binary cache#168
Merged
fulvius31 merged 1 commit intoredhat-et:mainfrom Feb 23, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes auto-detection of vLLM binary cache by updating the cache detection logic to recognize binary artifact files in addition to directory-based artifacts. The detection function previously only checked for triton/ subdirectories, causing binary artifacts to be misidentified as triton caches.
Changes:
- Updated
_has_artifact_compile_range_with_triton()to detect both binary artifact files and unpacked artifact directories - Synchronized requirements.txt with pyproject.toml for typer and structlog dependencies
- Added pylint configuration to suppress warnings for Pydantic models and import errors
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| mcm/requirements.txt | Synced dependency versions with pyproject.toml, pinned vllm version |
| mcm/pyproject.toml | Removed triton dependency, pinned vllm version, added pylint configuration |
| mcm/model_cache_manager/utils/utils.py | Fixed cache detection to recognize binary artifact files |
| mcm/model_cache_manager/tests/utils/test_cache_mode_detection.py | Added test case for binary artifact cache detection |
| mcm/model_cache_manager/data/kernel_validator.py | Added pylint disable comments for Pydantic model classes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
c20365d to
05b552b
Compare
05b552b to
d4096a0
Compare
_has_artifact_compile_range_with_triton() only checked for a triton/ subdirectory, which cannot exist when the artifact is a packed binary file. Recognize binary artifact_compile_range_* files as valid vLLM cache indicators so detect_cache_mode() returns 'vllm' instead of falling through to 'triton'. Also: - sync requirements.txt with pyproject.toml (typer[all], structlog) - silence pylint R0903 on Pydantic data models - disable pylint import-error for declared but not-installed deps Signed-off-by: Alessandro Sangiorgi <asangior@redhat.com>
d4096a0 to
fc95c7d
Compare
Collaborator
Author
maryamtahhan
approved these changes
Feb 23, 2026
maryamtahhan
pushed a commit
to maryamtahhan/MCU
that referenced
this pull request
Feb 25, 2026
_has_artifact_compile_range_with_triton() only checked for a triton/ subdirectory, which cannot exist when the artifact is a packed binary file. Recognize binary artifact_compile_range_* files as valid vLLM cache indicators so detect_cache_mode() returns 'vllm' instead of falling through to 'triton'. Also: - sync requirements.txt with pyproject.toml (typer[all], structlog) - silence pylint R0903 on Pydantic data models - disable pylint import-error for declared but not-installed deps Signed-off-by: Alessandro Sangiorgi <asangior@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
has_artifact_compile_range_with_triton() only checked for a triton/
subdirectory, which cannot exist when the artifact is a packed binary
file. Recognize binary artifact_compile_range* files as valid vLLM
cache indicators so detect_cache_mode() returns 'vllm' instead of
falling through to 'triton'.
Also: