fix: default VERTEX_PROVIDER when Vertex AI is skipped#1
Open
lkerriso wants to merge 1 commit intoredhat-et:mainfrom
Open
fix: default VERTEX_PROVIDER when Vertex AI is skipped#1lkerriso wants to merge 1 commit intoredhat-et:mainfrom
lkerriso wants to merge 1 commit intoredhat-et:mainfrom
Conversation
sallyom
force-pushed
the
main
branch
24 times, most recently
from
6c22802 to
5a99569
Compare
sallyom
force-pushed
the
main
branch
2 times, most recently
from
2cce133 to
61d8026
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When setup.sh reached the .env write block and I skipped Google Vertex AI, VERTEX_PROVIDER is not initialized, causing the script to crash with:
./scripts/setup.sh: line 394: VERTEX_PROVIDER: unbound variable
Fixed by applying the pattern used elsewhere in the script (lines 306 and 437).