refactor: update VSCode devcontainers to new architecture#123
Draft
cmagina wants to merge 1 commit intoredhat-et:mainfrom
Draft
refactor: update VSCode devcontainers to new architecture#123cmagina wants to merge 1 commit intoredhat-et:mainfrom
cmagina wants to merge 1 commit intoredhat-et:mainfrom
Conversation
Restructure VSCode devcontainer configurations to align with the new modular architecture and clearer naming conventions: New variant structure: - .devcontainer/cpu: CPU-only devcontainer - .devcontainer/cuda: NVIDIA CUDA devcontainer - .devcontainer/rocm: AMD ROCm devcontainer Base template changes: - Add create_user.template.sh (replaces user.sh) - Update devcontainer.template.json for new architecture - Rename postStartCommand.sh to postStartCommand.template.sh - Remove old user.sh Script updates: - Update bootstrap-devcontainer.sh for new structure - Update generate-devcontainers.sh for new variants Removed old variants: - .devcontainer/triton (replaced by cuda) - .devcontainer/triton-amd (replaced by rocm) - .devcontainer/triton-cpu (replaced by cpu) Benefits: - Clearer naming that reflects hardware support - Aligns with new Dockerfile structure from PR redhat-et#121 - Leverages modular setup scripts from PRs redhat-et#115-120 - Improves maintainability and consistency Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is part 9 of 11 in the rework modernization effort. It updates VSCode devcontainer configurations to align with the new modular architecture.
Changes:
.devcontainer/base/create_user.template.sh.devcontainer/base/devcontainer.template.jsonpostStartCommand.shtopostStartCommand.template.sh.devcontainer/base/user.shNew variant structure:
.devcontainer/cpu: CPU-only development.devcontainer/cuda: NVIDIA CUDA development.devcontainer/rocm: AMD ROCm developmentWhy this change?
The old devcontainer naming (triton, triton-amd, triton-cpu) was:
The new naming:
Testing:
Dependencies:
🤖 Generated with Claude Code