updating operator manifest tools with fixed panic and adding test case#1390
Open
acornett21 wants to merge 1 commit intoredhat-openshift-ecosystem:mainfrom
Open
updating operator manifest tools with fixed panic and adding test case#1390acornett21 wants to merge 1 commit intoredhat-openshift-ecosystem:mainfrom
acornett21 wants to merge 1 commit intoredhat-openshift-ecosystem:mainfrom
Conversation
openshift-ci
bot
added
the
approved
|
from change #1390: |
acornett21
changed the title
acornett21
force-pushed
the
fix_1384
branch
2 times, most recently
from
2138f43 to
70f4a77
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
This Pull Request effectively addresses the reported panic issue by updating the operator-manifest-tools dependency to version v0.12.0. It also correctly includes a new test case that verifies the system can gracefully handle empty relatedImages entries without crashing.
🔍 General Feedback
- The dependency updates in
go.modandgo.sumare straightforward and correct. - The newly added test case accurately simulates the bug scenario in
internal/policy/operator/certified_images_test.go. - Added a minor suggestion to the test logic to improve test coverage and resilience.
Signed-off-by: Adam D. Cornett <adc@redhat.com>
|
from change #1390: |
caxu-rh
approved these changes
Mar 19, 2026
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acornett21, caxu-rh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relatedImages.name || relatedImages.imageare Empty Strings #1384