Conversation
A user can specify an operator reviewer in the ci.yaml file in case-insensitive format. This however breaks a comparison that verifies that PR owner is in the list. This commit fixes it by converting all reviewers and PR owner into lowercase. JIRA: ISV-5404 Signed-off-by: Ales Raszka <araszka@redhat.com>
Allda
force-pushed
the
ISV-5404
branch
3 times, most recently
from
791951e to
0b12e2c
Compare
Replace Safety with pip-audit. The safety used an old cve database and requires a licence for commercial use. Signed-off-by: Ales Raszka <araszka@redhat.com>
BorekZnovustvoritel
approved these changes
Jan 2, 2025
Contributor
BorekZnovustvoritel
left a comment
BorekZnovustvoritel
left a comment
There was a problem hiding this comment.
I have only a single non-blocking nit-pick for code consistency. LGTM 👍
| operator in lowercase format | ||
| """ | ||
| return self.base_repo_operator_config.get("reviewers") or [] | ||
| reviewers = self.base_repo_operator_config.get("reviewers") or [] |
Contributor
There was a problem hiding this comment.
I am wondering if maybe we want to also make this change for the property maintainers? But It seems that maintainers not being unified to lowercase don't break anything, so this is just a thought.
Contributor
Author
There was a problem hiding this comment.
I was initially also thinking about it but then I rejected the idea because we control the list of maintainers (we can edit it anytime) and it is not used the same way as the list of reviewers.
Contributor
There was a problem hiding this comment.
Good argument. Feel free to disregard my comment and merge as-is 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Request Checklists