Skip to content

Comments

remove --verbose flag from scratch fbc building task#884

Merged
Allda merged 1 commit intomainfrom
remove_verbose_flag
Jan 20, 2026
Merged

remove --verbose flag from scratch fbc building task#884
Allda merged 1 commit intomainfrom
remove_verbose_flag

Conversation

@acornett21
Copy link
Contributor

@acornett21 acornett21 commented Jan 19, 2026

Merge Request Checklists

  • Development is done in feature branches
  • Code changes are submitted as pull request into a primary branch [Provide reason for non-primary branch submissions]
  • Code changes are covered with unit and integration tests.
  • Code passes all automated code tests:
    • Linting
    • Code formatter - Black
    • Security scanners
    • Unit tests
    • Integration tests
  • Code is reviewed by at least 1 team member
  • Pull request is tagged with "risk/good-to-go" label for minor changes

Motivation

This --verbose flag seems to just be left over developer logic. This extra flag doesn't seem to yield any value for partners or support, since it's just logging encoded json of the FBC yaml. The issue with this logging is that it blocks partners that have operators with multiple CRD's/resources in their bundle from being able to update their logs to our pipeline. This in tern means there is a failure/error in their CI that calls this CI pipeline.

We still get the necessary info to support failures in this task without this flag, see the below log output

[build-fbc-scratch-catalog : build-fbc-catalog] + EXTRA_ARGS=
[build-fbc-scratch-catalog : build-fbc-catalog] + [[ true == \t\r\u\e ]]
[build-fbc-scratch-catalog : build-fbc-catalog] + DOCKERCONFIGJSON=/workspace/credentials/.dockerconfigjson
[build-fbc-scratch-catalog : build-fbc-catalog] + EXTRA_ARGS+=' --authfile /workspace/credentials/.dockerconfigjson'
[build-fbc-scratch-catalog : build-fbc-catalog] + export REGISTRY_AUTH_FILE=/workspace/credentials/.dockerconfigjson
[build-fbc-scratch-catalog : build-fbc-catalog] + REGISTRY_AUTH_FILE=/workspace/credentials/.dockerconfigjson
[build-fbc-scratch-catalog : build-fbc-catalog] + CATALOG_REPO=quay.io/acornett/simple-demo-operator-index:v4.21-v0.0.8
[build-fbc-scratch-catalog : build-fbc-catalog] + build-scratch-catalog --repo-path . --operator-name simple-demo-operator --bundle-version v0.0.8 --bundle-pullspec quay.io/acornett/simple-demo-operator-bundle:v0.0.8 --repository-destination quay.io/acornett/simple-demo-operator-index:v4.21-v0.0.8 --authfile /workspace/credentials/.dockerconfigjson
[build-fbc-scratch-catalog : build-fbc-catalog] 2026-01-19 21:48:52,796 [operator-cert] INFO Building image: quay.io/acornett/simple-demo-operator-index:v4.21-v0.0.8
[build-fbc-scratch-catalog : build-fbc-catalog] 2026-01-19 21:49:01,272 [operator-cert] INFO Pushing image: quay.io/acornett/simple-demo-operator-index:v4.21-v0.0.8

Signed-off-by: Adam D. Cornett <adc@redhat.com>
@Allda Allda merged commit 9ef4747 into main Jan 20, 2026
10 of 15 checks passed
@Allda Allda deleted the remove_verbose_flag branch January 20, 2026 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants