Skip to content

v1.2.0

Latest

Choose a tag to compare

@github-actions github-actions released this 13 Feb 13:10

v1.2.0 (2026-02-13)

Bug Fixes

  • Apply black fixes, more test cov for nic attr (b31e537)

  • Incorrect credentials are masked by traceback (54fa694)

  • find_session_uri masks a proper error message when someone passes incorrect credentials (either by vars or user/pass). * response body seems to be a JSON object and not a redfish root object and we are not generating a useful error, instead the user gets a traceback that masks the real cause.

before (see #517)

after

-=>>PYTHONPATH="./src" python3 src/badfish/main.py -H mgmt-d23-h31-000-r650.example.com -u root -p awrongpassword --power-state - WARNING - Passing secrets via command line arguments can be unsafe. Consider using environment variables (BADFISH_USERNAME, BADFISH_PASSWORD). - ERROR - Failed to authenticate. Verify your credentials for mgmt-d23-h31-000-r650.example.com

  • Also remove asyncio import from tests/test_main_coverage.py as it wasn't being utilized.

fixes: #517

Chores

  • Address mock whitespace in tests (05b409b)

  • Fix debug logger typo (0116cb7)

  • Fix indentation (073efca)

  • Fix last coverage lines (f2d4637)

  • Fix tests spacing on returns (a113725)

  • Fully revert old_password,new_password env (3de528b)

  • Further tests adjustment (0741776)

  • I grow weary of adjusting test intricacies (3c68a68)

  • Refactor test_main_coverage.py for black (42d4911)

  • Remove new/reset/old password handling (1e9298e)

  • This is clumsy and very unlikely these values will be an env variable.
  • Nothing keeps people from securing it with a temporary export but it
    is not in scope for using stored env vars which tend to be static or change rarely and thus makes more sense to concentrate on for this feature.
  • Revert, fix up only affected tests (848a4e8)

  • Set test vars in config.py (4ec3b1d)

  • Spacing again on tests (4661d74)

  • Test modifications (d3568f0)

  • Try to fix failing tests and tox (b1e14b2)

  • Try two on aligning spacing for log msgs (0a67bda)

  • Update doc examples by suggest (52f721b)

  • We should not need mock user/pass now (805cdad)

  • Whitespace and unsafe_secrets for tests (01ff58a)

Features

  • Support auth via env vars (38cc4e0)
  • Add these new vars for safer badfishing

    • BADFISH_PASSWORD
    • BADFISH_USERNAME
    • BADFISH_NEW_PASSWORD
    • BADFISH_OLD_PASSWORD
  • Update venv example for PYTHONPATH

fixes: #496


Detailed Changes: v1.1.1...v1.2.0