Support BENCHMARK_OPERATOR_NAMESPACE for OpenShift/release CI#1184
Merged
Support BENCHMARK_OPERATOR_NAMESPACE for OpenShift/release CI#1184
Conversation
When set, use BENCHMARK_OPERATOR_NAMESPACE for workload/operator namespace so CI can leave NAMESPACE as the job namespace for the result secret. Fixes permission error: framework cannot write secret in benchmark-operator on the build cluster.
|
Skipping CI for Draft Pull Request. |
RobertKrawitz
approved these changes
Mar 2, 2026
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arpsharm, ebattat, RobertKrawitz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Note: Fill x in []
Description
Add support for BENCHMARK_OPERATOR_NAMESPACE. When set, the app uses it for the workload/operator namespace and no longer relies on NAMESPACE for that. The CI framework can keep using NAMESPACE as the job namespace for the result secret, avoiding the “cannot update secret in namespace benchmark-operator” error. Workloads still run in benchmark-operator on the test cluster. Release repo will set BENCHMARK_OPERATOR_NAMESPACE=benchmark-operator and drop NAMESPACE from the step ref after this is merged.