Remove stale benchmark_operator_id and benchmark_wrapper_id from update_ci_status#1189
Remove stale benchmark_operator_id and benchmark_wrapper_id from update_ci_status#1189
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: arpsharm The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
arpsharm
changed the title
ebattat
left a comment
ebattat
left a comment
There was a problem hiding this comment.
Is it the only place we use it ?
| benchmark_runner_id=benchmark_runner_id, | ||
| benchmark_operator_id=benchmark_operator_id, | ||
| benchmark_wrapper_id=benchmark_wrapper_id) | ||
| benchmark_runner_id=benchmark_runner_id) |
There was a problem hiding this comment.
Is it the only place we use benchmark_operator_id and benchmark_wrapper_id ?
There was a problem hiding this comment.
Yes it was the only file being directly affected at runtime. However, there were stale references as well set in the yaml files, usually harmless but I removed that from there as well just to be consistent.
There was a problem hiding this comment.
can u remove it from jenkinsfiles also ?
There was a problem hiding this comment.
I don't see any more references for this in Jenkinsfiles. Am I missing something?
arpsharm
force-pushed
the
fix-update-ci-status
branch
from
9bcf527 to
af9b03e
Compare
2 participants
Type of change
Description
update_ci_status()inmain.pystill passedbenchmark_operator_idandbenchmark_wrapper_idto the method inworkloads_operations.py, but those parameters were removed in PR #1186 . This causes aTypeErrorat runtime whenci_statusispassorfailed.