Add public_vlan validation for controlplane_network private subnet

[mcornea]

No description provided.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign akrzos for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[akrzos]

/test ?

[openshift-ci]

@akrzos: The following commands are available to trigger required jobs:

/test deploy-cmno

/test deploy-cmno-private

/test deploy-cmno-private-bond

/test deploy-hmno

/test deploy-hmno-private

/test deploy-mno

/test deploy-mno-private

/test deploy-mno-private-bond

/test deploy-mno-scaleout

/test deploy-sno

/test deploy-sno-private

/test deploy-sno-private-bond

/test deploy-sno-scaleout

/test deploy-sno-self-sched

/test deploy-vmno

/test deploy-vmno-private

Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[akrzos]

/test deploy-mno

[akrzos]

/test deploy-mno

[openshift-ci]

@mcornea: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/deploy-mno	33cd82b	link	true	/test deploy-mno

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[akrzos]

Needs some work

[akrzos]

Need to check if controlplane_network is defined first. However even worse is that it seems somehow the default in the following role in the networks.yml vars file is populated before it is used thus the value remains assigned when I was debugging the CI failure. Even if we then remove that definition, a later validation for controlplane_network to be a list will also fail. We should also move from fail to assert tasks as those better match the goal of validate vars perhaps before adding more validations.