systemd: used drop-ins for configuration#829
Conversation
|
/packit build |
1 similar comment
|
/packit build |
| %config(noreplace) %verify(not size mtime md5) %{_sysconfdir}/tuned/bootcmdline | ||
| %verify(not size mtime md5) %{_sysconfdir}/modprobe.d/tuned.conf | ||
| # https://bugzilla.redhat.com/show_bug.cgi?id=2444143 | ||
| %dir %{_sysconfdir}/systemd/system.conf.d |
There was a problem hiding this comment.
Assuming this will be there until the systemd package actually starts to provide the system.conf.d directory?
There was a problem hiding this comment.
Yes, I hope they will add it. If not, we can keep it. Even in case they add it and we forget to drop it, it will be still according to the Fedora packaging guidelines, because co-ownership of directories is allowed.
|
@Fothsid I improved the PR a bit, now it tries to create the systemd template (if it doesn't exist) which may help in cases where the template is not installed. Please re-review. |
| @@ -0,0 +1 @@ | |||
| [Manager] | |||
There was a problem hiding this comment.
Wouldn't this file be completely unnecessary after the change?
There was a problem hiding this comment.
Actually, I guess it's still useful to have it there so that it is removed together with the whole package and wouldn't leave a random configuration file.
There was a problem hiding this comment.
Actually, I guess it's still useful to have it there so that it is removed together with the whole package and wouldn't leave a random configuration file.
Yes, it's always better to have the package manager to handle it - it will also backup the file in case user already has there his own configuration file with the same name.
The code in the plugin is just a fallback for special cases when the template file is not installed by RPM or make install, e.g. it could happen on some non RPM distro. IMHO in such case it's better if the plugin works OK and creates the file that could be a leftover later than if it doesn't work.
yarda
force-pushed
the
systemd-dropins
branch
2 times, most recently
from
7f3f9cd to
f3b3900
Compare
Resolves: RHEL-97580 Signed-off-by: Jaroslav Škarvada <jskarvad@redhat.com>
|
Fixed conflict and rebased onto master. |
2 participants
Resolves: RHEL-97580