Skip to content

actions: build docs only in the upstream repo (not in private forks)#839

Merged
yarda merged 1 commit intoredhat-performance:masterfrom
yarda:build-docs-only-in-master
Mar 23, 2026
Merged

actions: build docs only in the upstream repo (not in private forks)#839
yarda merged 1 commit intoredhat-performance:masterfrom
yarda:build-docs-only-in-master

Conversation

@yarda
Copy link
Contributor

@yarda yarda commented Mar 19, 2026

This should stop contributors receiving the "deployment failed" e-mails.

@yarda yarda requested a review from Fothsid March 19, 2026 15:38
Copy link
Contributor

@Fothsid Fothsid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be inside ${{ }}? Like so:

if: ${{ github.repository == 'redhat-performance/tuned' }}

(See https://docs.github.com/en/actions/how-tos/write-workflows/choose-when-workflows-run/control-jobs-with-conditions)

@yarda
Copy link
Contributor Author

yarda commented Mar 19, 2026

Shouldn't it be inside ${{ }}? Like so:

if: ${{ github.repository == 'redhat-performance/tuned' }}

(See https://docs.github.com/en/actions/how-tos/write-workflows/choose-when-workflows-run/control-jobs-with-conditions)

IMHO from: https://docs.github.com/en/actions/reference/workflows-and-actions/metadata-syntax#runsstepsif:

When you use expressions in an if conditional, you can, optionally, omit the ${{ }} expression syntax because GitHub Actions automatically evaluates the if conditional as an expression. However, this exception does not apply everywhere.

But I agree it's more readable with the explicit evaluation, I will fix it.

This should stop contributors receiving the "deployment failed" e-mails.

Signed-off-by: Jaroslav Škarvada <jskarvad@redhat.com>
@yarda yarda force-pushed the build-docs-only-in-master branch from a04a37f to ef78f21 Compare March 19, 2026 18:21
Copy link
Contributor

@Fothsid Fothsid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yarda yarda merged commit 6246185 into redhat-performance:master Mar 23, 2026
18 checks passed
@yarda yarda deleted the build-docs-only-in-master branch March 23, 2026 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants