Skip to content

update escape() to escape multiple | in commit message#209

Merged
jamacku merged 2 commits intoredhat-plumbers-in-action:mainfrom
jamacku:main
Jul 18, 2025
Merged

update escape() to escape multiple | in commit message#209
jamacku merged 2 commits intoredhat-plumbers-in-action:mainfrom
jamacku:main

Conversation

@jamacku
Copy link
Member

@jamacku jamacku commented Jul 18, 2025

No description provided.

@jamacku jamacku requested a review from Copilot July 18, 2025 10:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the escape() function to properly handle multiple pipe characters (|) in commit messages by using a global regex replacement instead of replacing only the first occurrence. Additionally, the PR includes dependency updates for various packages including Yarn, Octokit, and Zod.

  • Enhanced the escape() function to replace all pipe characters globally using regex
  • Added comprehensive test cases to verify escaping behavior with multiple pipes
  • Updated package manager and dependencies to newer versions

Reviewed Changes

Copilot reviewed 4 out of 13 changed files in this pull request and generated no comments.

File Description
src/util.ts Updated escape function to use global regex for replacing all pipe characters
test/unit/util.test.ts Added test cases for escaping multiple pipe characters scenarios
package.json Updated Yarn package manager and various dependencies to newer versions
.yarnrc.yml Updated Yarn path to match new package manager version

@codecov
Copy link

codecov bot commented Jul 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.79%. Comparing base (429beaf) to head (9806248).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #209   +/-   ##
=======================================
  Coverage   27.79%   27.79%           
=======================================
  Files           7        7           
  Lines         259      259           
  Branches       23       23           
=======================================
  Hits           72       72           
  Misses        183      183           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jamacku jamacku merged commit b3dbc3f into redhat-plumbers-in-action:main Jul 18, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants