update escape() to escape multiple | in commit message#209
Merged
jamacku merged 2 commits intoredhat-plumbers-in-action:mainfrom Jul 18, 2025
Merged
update escape() to escape multiple | in commit message#209jamacku merged 2 commits intoredhat-plumbers-in-action:mainfrom
escape() to escape multiple | in commit message#209jamacku merged 2 commits intoredhat-plumbers-in-action:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the escape() function to properly handle multiple pipe characters (|) in commit messages by using a global regex replacement instead of replacing only the first occurrence. Additionally, the PR includes dependency updates for various packages including Yarn, Octokit, and Zod.
- Enhanced the
escape()function to replace all pipe characters globally using regex - Added comprehensive test cases to verify escaping behavior with multiple pipes
- Updated package manager and dependencies to newer versions
Reviewed Changes
Copilot reviewed 4 out of 13 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/util.ts | Updated escape function to use global regex for replacing all pipe characters |
| test/unit/util.test.ts | Added test cases for escaping multiple pipe characters scenarios |
| package.json | Updated Yarn package manager and various dependencies to newer versions |
| .yarnrc.yml | Updated Yarn path to match new package manager version |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #209 +/- ##
=======================================
Coverage 27.79% 27.79%
=======================================
Files 7 7
Lines 259 259
Branches 23 23
=======================================
Hits 72 72
Misses 183 183
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.