Skip to content

chore: enhance .distro/list_issues.sh#130

Open
pvalena wants to merge 2 commits intomainfrom
list-issues
Open

chore: enhance .distro/list_issues.sh#130
pvalena wants to merge 2 commits intomainfrom
list-issues

Conversation

@pvalena
Copy link
Copy Markdown
Contributor

@pvalena pvalena commented Mar 4, 2026

No description provided.

regardless of whether it's mounted.

(cherry picked from commit 9d63c6ad9180fde668cb7d259e8f445d1f5677ea)
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 4, 2026

Commit validation

Tracker - Missing issue tracker ✋

The following commits need an inspection

commit note
bce0d2c - chore: enhance .distro/list_issues.sh Missing issue tracker
Missing upstream reference ‼️

Tracker validation

🔴 Missing tracker or Unknown tracker type; type: 'unknown'


Pull Request validation

Failed

🔴 Failed or pending checks:

  • test (centos:stream9, 31)[failure]
  • test (centos:stream9, 30)[failure]
  • test (centos:stream9, 03)[failure]
  • test (centos:stream9, 35)[failure]
  • test (centos:stream9, 15)[failure]
  • test (centos:stream9, 36)[failure]
  • test (centos:stream9, 14)[failure]
  • centos-9-stream (centos:stream9, 10)[cancelled]
  • centos-9-stream (centos:stream9, 40)[cancelled]
  • centos-9-stream (centos:stream9, 41)[cancelled]
  • centos-9-stream (centos:stream9, 01)[cancelled]
  • centos-9-stream (centos:stream9, 20)[cancelled]
  • centos-9-stream (centos:stream9, 13)[cancelled]
  • centos-9-stream (centos:stream9, 16)[cancelled]
  • centos-9-stream (centos:stream9, 21)[cancelled]
  • centos-9-stream (centos:stream9, 02)[cancelled]
  • centos-9-stream (centos:stream9, 98)[cancelled]
  • centos-9-stream (centos:stream9, 17)[cancelled]
  • centos-9-stream (centos:stream9, 12)[cancelled]
  • centos-9-stream (centos:stream9, 11)[cancelled]
  • basic (centos:stream9, 04)[failure]
  • testing-farm:centos-stream-9-x86_64[in_progress]
  • rpm-build:centos-stream-9-aarch64[in_progress]
  • rpm-build:centos-stream-9-x86_64[in_progress]
  • test (centos:stream9, 10)[in_progress]
  • test (centos:stream9, 16)[in_progress]
  • test (centos:stream9, 13)[in_progress]
  • test (centos:stream9, 02)[in_progress]
  • test (centos:stream9, 17)[in_progress]
  • test (centos:stream9, 40)[in_progress]
  • test (centos:stream9, 41)[in_progress]
  • test (centos:stream9, 12)[in_progress]
  • test (centos:stream9, 01)[in_progress]
  • test (centos:stream9, 21)[in_progress]
  • test (centos:stream9, 20)[in_progress]
  • test (centos:stream9, 11)[in_progress]
  • lint-shell[in_progress]

🔴 Review - Missing review from a member (1 required)

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 4, 2026

sh-checker report

To get the full details, please check in the job output.

shellcheck errors

'shellcheck ' returned error 1 finding the following syntactical issues:

----------

In .distro/backport_fix.sh line 1:
#!/usr/bin/env zsh
^-- SC1071: ShellCheck only supports sh/bash/dash/ksh scripts. Sorry!


In .distro/list_issues.sh line 1:
#!/usr/bin/env zsh
^-- SC1071: ShellCheck only supports sh/bash/dash/ksh scripts. Sorry!

For more information:
  https://www.shellcheck.net/wiki/SC1071 -- ShellCheck only supports sh/bash/...
----------

You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
  # shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.



shfmt errors

'shfmt -s' returned error 1 finding the following formatting issues:

----------
--- .distro/list_issues.sh.orig
+++ .distro/list_issues.sh
@@ -5,24 +5,24 @@
 zsh -n "$0"
 
 : "debug"
-[[ "$1" == '-d' ]] && {
-  set -x
-  shift ||:
-  :
+[[ $1 == '-d' ]] && {
+    set -x
+    shift || :
+    :
 }
 
 : "No fails on check"
-[[ "$1" == '-n' ]] && {
-  NOFAIL=y
-  shift ||:
-  :
+[[ $1 == '-n' ]] && {
+    NOFAIL=y
+    shift || :
+    :
 } || NOFAIL=
 
 : "Ignore build commits (defaults to failure)"
-[[ "$1" == '-i' ]] && {
-  IGNORE=y
-  shift ||:
-  :
+[[ $1 == '-i' ]] && {
+    IGNORE=y
+    shift || :
+    :
 } || IGNORE=
 #clear
 
@@ -55,59 +55,59 @@
 zsh -n -c "$cmd"
 
 res="$(
-  echo "$all" | cut -d' ' -f1 \
-    | xargs -ri zsh -c "$cmd" \
-    | tr -s '\t' ' ' | sed -e 's/^\s*//g'
-)" ||:
+    echo "$all" | cut -d' ' -f1 \
+        | xargs -ri zsh -c "$cmd" \
+        | tr -s '\t' ' ' | sed -e 's/^\s*//g'
+)" || :
 
-[[ -n "$res" && "$res" =~ "$ok" ]]
+[[ -n $res && $res =~ $ok ]]
 
-[[ -n "$NOFAIL" ]] && {
+[[ -n $NOFAIL ]] && {
 
-  echo
-  lst="$(
-  echo "$res" | cut -d' ' -f2 \
-    | while read c; do
-      m="$(grep -E "^$c " <<< "$all" | cut -d' ' -f2-)"
+    echo
+    lst="$(
+        echo "$res" | cut -d' ' -f2 \
+            | while read c; do
+                m="$(grep -E "^$c " <<< "$all" | cut -d' ' -f2-)"
 
-      echo "$m" | grep -qE '^(ci|chore|test): ' \
-        || echo "- $m"
+                echo "$m" | grep -qE '^(ci|chore|test): ' \
+                    || echo "- $m"
 
-    done | reverse -l
-  )"
+            done | reverse -l
+    )"
 
-  :
+    :
 } || {
-  echo "$res" | grep -E "^Missing" | cut -d' ' -f2 \
-    | while read c; do
-      m="$(grep -E "^$c " <<< "$all" | cut -d' ' -f2-)"
-      echo "$m" | grep -qE '^(build|ci|chore|test): ' || {
-        echo "FAIL: $m"
-        gith "$c" | cat
-        echo
-        exit 255
-      }
-    done
+    echo "$res" | grep -E "^Missing" | cut -d' ' -f2 \
+        | while read c; do
+            m="$(grep -E "^$c " <<< "$all" | cut -d' ' -f2-)"
+            echo "$m" | grep -qE '^(build|ci|chore|test): ' || {
+                echo "FAIL: $m"
+                gith "$c" | cat
+                echo
+                exit 255
+            }
+        done
 
-  echo
-  lst="$(
-  echo "$res" | grep -E "^Found" | cut -d' ' -f2 \
-    | while read c; do
-      m="$(grep -E "^$c " <<< "$all" | cut -d' ' -f2-)"
+    echo
+    lst="$(
+        echo "$res" | grep -E "^Found" | cut -d' ' -f2 \
+            | while read c; do
+                m="$(grep -E "^$c " <<< "$all" | cut -d' ' -f2-)"
 
-      echo "$m" | grep -qE '^(ci): ' && {
+                echo "$m" | grep -qE '^(ci): ' && {
 
-        [[ -n "$IGNORE" ]] && continue
+                    [[ -n $IGNORE ]] && continue
 
-        echo ">> False: $m"
-        gith "$c" | cat
-        echo
-        exit 255
+                    echo ">> False: $m"
+                    gith "$c" | cat
+                    echo
+                    exit 255
 
-      } >&2 || echo "- $m"
+                } >&2 || echo "- $m"
 
-    done | reverse -l
-  )"
+            done | reverse -l
+    )"
 }
 
 # 80
@@ -115,11 +115,11 @@
 echo "$ln"
 echo "$lst"
 
-isu="$(echo "$res"| grep -E "$gr" | cut -d' ' -f2 | sort -u | xargs -ri echo -n '{},')"
+isu="$(echo "$res" | grep -E "$gr" | cut -d' ' -f2 | sort -u | xargs -ri echo -n '{},')"
 
 echo "  Resolves: ${isu%,}"
 echo "$ln"
 echo
 #tr -s ',' '\n' <<< "$res" | sed -e 's/^/Resolves: /g'
 
-echo "$res"| grep -E "$gr" | sort -u
+echo "$res" | grep -E "$gr" | sort -u
----------

You can reformat the above files to meet shfmt's requirements by typing:

  shfmt -s -w filename


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant