Skip to content

Commit 7217ca6

Browse files
committed
fix backend tests
1 parent 3d2086a commit 7217ca6

File tree

3 files changed

+21
-10
lines changed

3 files changed

+21
-10
lines changed

src/action/mod.rs

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -456,6 +456,16 @@ impl Action {
456456
action
457457
}
458458

459+
// pub fn get_final_status_code_with_fallback(&mut self, response_status_code: u16, fallback_status_code: u16, unit_trace: Option<&mut UnitTrace>) -> (u16, u16) {
460+
// let action_status_code = self.get_status_code(response_status_code, Some(&mut unit_trace.unwrap()));
461+
// if response_status_code == 0 && action_status_code == 0 {
462+
// let final_status_code = self.get_status_code(fallback_status_code, Some(&mut unit_trace.unwrap()));
463+
// (final_status_code, fallback_status_code)
464+
// } else {
465+
// (action_status_code, response_status_code)
466+
// }
467+
// }
468+
459469
pub fn get_status_code(&mut self, response_status_code: u16, unit_trace: Option<&mut UnitTrace>) -> u16 {
460470
match self.status_code_update.as_ref() {
461471
None => 0,

src/api/explain_request.rs

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -75,13 +75,14 @@ impl ExplainRequestOutput {
7575

7676
let example_status_code = example.response_status_code.unwrap_or(0);
7777
let action_status_code = action.get_status_code(example_status_code, Some(&mut unit_trace));
78-
let (final_status_code, backend_status_code) = if action_status_code != 0 {
79-
(action_status_code, action_status_code)
78+
let (final_status_code, backend_status_code) = if example_status_code == 0 && action_status_code == 0 {
79+
let fallback_status_code = 200;
80+
let final_status_code = action.get_status_code(fallback_status_code, Some(&mut unit_trace));
81+
(final_status_code, fallback_status_code)
8082
} else {
81-
let backend_status_code = example.response_status_code.unwrap_or(200);
82-
let final_status_code = action.get_status_code(backend_status_code, Some(&mut unit_trace));
83-
(final_status_code, example_status_code)
83+
(action_status_code, example_status_code)
8484
};
85+
// let (final_status_code, backend_status_code) = action.get_final_status_code_with_fallback(example_status_code, 200, Some(&mut unit_trace));
8586

8687
let headers = action.filter_headers(Vec::new(), backend_status_code, false, Some(&mut unit_trace));
8788

src/api/impact.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -139,12 +139,12 @@ impl ImpactOutput {
139139

140140
let example_status_code = example.response_status_code.unwrap_or(0);
141141
let action_status_code = action.get_status_code(example_status_code, Some(&mut unit_trace));
142-
let (final_status_code, backend_status_code) = if action_status_code != 0 {
143-
(action_status_code, action_status_code)
142+
let (final_status_code, backend_status_code) = if example_status_code == 0 && action_status_code == 0 {
143+
let fallback_status_code = 200;
144+
let final_status_code = action.get_status_code(fallback_status_code, Some(&mut unit_trace));
145+
(final_status_code, fallback_status_code)
144146
} else {
145-
let backend_status_code = example.response_status_code.unwrap_or(200);
146-
let final_status_code = action.get_status_code(backend_status_code, Some(&mut unit_trace));
147-
(final_status_code, example_status_code)
147+
(action_status_code, example_status_code)
148148
};
149149

150150
let headers = action.filter_headers(Vec::new(), backend_status_code, false, Some(&mut unit_trace));

0 commit comments

Comments
 (0)