Skip to content

feat: add cluster support #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nkaradzhov merged 4 commits into from
Oct 21, 2025
Merged

feat: add cluster support #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
95673f3
feat: add cluster support
nkaradzhov Oct 21, 2025
98a3c22
fix formatting
nkaradzhov Oct 21, 2025
861d748
fix linting & formatting
nkaradzhov Oct 21, 2025
2e3a0be
update node-redis dep
nkaradzhov Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 25 additions & 25 deletions bun.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"dependencies": {
"@hono/zod-validator": "^0.7.2",
"hono": "^4.8.5",
"redis-monorepo": "github:redis/node-redis",
"redis-monorepo": "github:redis/node-redis#master",
"zod": "^4.0.8"
},
"devDependencies": {
Expand Down
37 changes: 20 additions & 17 deletions src/app.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,19 @@ import {
type RedisProxy,
} from "redis-monorepo/packages/test-utils/lib/redis-proxy.ts";
import { createApp } from "./app";
import { makeId } from "./proxy-store";

const TARGET_HOST = "127.0.0.1";

describe("Redis Proxy API", () => {
let app: any;
let proxy: RedisProxy;
let mockRedisServer: any;
let targetPort: number;

beforeAll(async () => {
const freePort = await getFreePortNumber();
const targetPort = await getFreePortNumber();
targetPort = await getFreePortNumber();

mockRedisServer = Bun.listen({
hostname: "127.0.0.1",
Expand Down Expand Up @@ -85,7 +89,7 @@ describe("Redis Proxy API", () => {
const testConfig = {
listenPort: freePort,
listenHost: "127.0.0.1",
targetHost: "127.0.0.1",
targetHost: TARGET_HOST,
targetPort: targetPort,
timeout: 30000,
enableLogging: true,
Expand Down Expand Up @@ -113,7 +117,7 @@ describe("Redis Proxy API", () => {
const res = await app.request("/stats");
expect(res.status).toBe(200);

const stats = await res.json();
const stats = (await res.json())[makeId(TARGET_HOST, targetPort)];
expect(stats).toHaveProperty("activeConnections");
expect(stats).toHaveProperty("totalConnections");
expect(stats).toHaveProperty("connections");
Expand All @@ -125,10 +129,9 @@ describe("Redis Proxy API", () => {
const res = await app.request("/connections");
expect(res.status).toBe(200);

const result = await res.json();
expect(result).toHaveProperty("connectionIds");
expect(Array.isArray(result.connectionIds)).toBe(true);
expect(result.connectionIds.length).toBe(0);
const result = (await res.json())[makeId(TARGET_HOST, targetPort)];
expect(result).toBeArray();
expect(result.length).toBe(0);
});

test("POST /send-to-client with invalid connection", async () => {
Expand Down Expand Up @@ -217,16 +220,16 @@ describe("Redis Proxy API", () => {

const statsRes = await app.request("/stats");
expect(statsRes.status).toBe(200);
const stats = await statsRes.json();
const stats = (await statsRes.json())[makeId(TARGET_HOST, targetPort)];
expect(stats.activeConnections).toBe(1);
expect(stats.totalConnections).toBeGreaterThanOrEqual(1);
expect(stats.connections.length).toBe(1);

const connectionsRes = await app.request("/connections");
expect(connectionsRes.status).toBe(200);
const connectionsResult = await connectionsRes.json();
expect(connectionsResult.connectionIds.length).toBe(1);
const connectionId = connectionsResult.connectionIds[0];
const connectionsResult = (await connectionsRes.json())[makeId(TARGET_HOST, targetPort)];
expect(connectionsResult.length).toBe(1);
const connectionId = connectionsResult[0];
expect(typeof connectionId).toBe("string");
expect(connectionId.length).toBeGreaterThan(0);

Expand Down Expand Up @@ -255,7 +258,7 @@ describe("Redis Proxy API", () => {
await new Promise((resolve) => setTimeout(resolve, 100));

const finalStatsRes = await app.request("/stats");
const finalStats = await finalStatsRes.json();
const finalStats = (await finalStatsRes.json())[makeId(TARGET_HOST, targetPort)];
expect(finalStats.activeConnections).toBe(0);

resolve();
Expand Down Expand Up @@ -289,15 +292,15 @@ describe("Redis Proxy API", () => {
await new Promise((resolve) => setTimeout(resolve, 100));

const statsRes = await app.request("/stats");
const stats = await statsRes.json();
const stats = (await statsRes.json())[makeId(TARGET_HOST, targetPort)];
expect(stats.activeConnections).toBe(1);
expect(stats.totalConnections).toBeGreaterThanOrEqual(1);
expect(stats.connections.length).toBe(1);

const connectionsRes = await app.request("/connections");
const connectionsResult = await connectionsRes.json();
expect(connectionsResult.connectionIds.length).toBe(1);
const connectionId = connectionsResult.connectionIds[0];
const connectionsResult = (await connectionsRes.json())[makeId(TARGET_HOST, targetPort)];
expect(connectionsResult.length).toBe(1);
const connectionId = connectionsResult[0];

const result = await client.sendCommand(["FOO"]);
expect(result).toBe("BAR" as unknown as SimpleStringReply);
Expand All @@ -319,7 +322,7 @@ describe("Redis Proxy API", () => {
await new Promise((resolve) => setTimeout(resolve, 100));

const finalStatsRes = await app.request("/stats");
const finalStats = await finalStatsRes.json();
const finalStats = (await finalStatsRes.json())[makeId(TARGET_HOST, targetPort)];
expect(finalStats.activeConnections).toBe(0);
});
});
Loading