Use watches on compare-and-set pipelines #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsbodden
force-pushed
the
main
branch
2 times, most recently
from
4377b7b to
9f9ff0d
Compare
abrookins
force-pushed
the
RAE-603/pipeline-semantics
branch
from
db32479 to
bcec7fc
Compare
bsbodden
requested changes
Feb 7, 2025
There was a problem hiding this comment.
Just a few linter complains. And for the commit message would you mind using https://www.conventionalcommits.org/en/v1.0.0/
I've been using ChatGPT/Claude to give me the proper tag for the commit (and we are free to add our own too)
abrookins
force-pushed
the
RAE-603/pipeline-semantics
branch
from
6c00956 to
c4c5ff6
Compare
| return ChatOpenAI(model="gpt-4-turbo-preview", temperature=0) | ||
|
|
||
|
|
||
| @pytest.mark.requires_api_keys |
There was a problem hiding this comment.
I love this technique and it's something we should implement over the pond at RedisVL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_async_store_with_memory_persistenceNOTE: These objects must be used within their context blocks because once control exits the block, they free resources. This is by design, but it means our examples need to show how to do this properly. (We should double-check them.) Either
async with/withcan be used, or an exit stack (async exit stack for async ...).