fix: Support cluster clients in saver #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Redis Cluster to both synchronous and asynchronous checkpoint savers, enabling cluster-aware TTL, deletion, and index setup operations.
- Updated tests in both sync and async modules to validate cluster vs. non-cluster behaviors.
- Modified type annotations and client detection in RedisSaver and AsyncRedisSaver to support both standalone and cluster clients.
- Refactored TTL application and key deletion logic to account for cluster-specific operation differences.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_cluster_mode.py | Added fixture and tests for verifying cluster mode behavior in RedisSaver. |
| tests/test_async_cluster_mode.py | Added async fixture and tests for verifying cluster mode in AsyncRedisSaver. |
| langgraph/store/redis/base.py | Removed unused imports and cleaned up type usage. |
| langgraph/checkpoint/redis/types.py | Extended RedisClientType union to include cluster clients. |
| langgraph/checkpoint/redis/base.py | Updated TTL handling to differentiate between cluster and non-cluster modes. |
| langgraph/checkpoint/redis/aio.py | Enhanced AsyncRedisSaver with cluster detection and separated logic. |
| langgraph/checkpoint/redis/init.py | Modified RedisSaver to support both standalone and cluster clients. |
bsbodden
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Redis Cluster to the
RedisSaverandAsyncRedisSaversimilar to that added for the "store" classes.Fixes #55