fix: handle missing connection_pool attribute in RedisCluster (#93) #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RedisCluster doesn't have the connection_pool attribute that standard Redis clients have. This causes an AttributeError when using from_conn_string() context managers with Redis deployments that use proxy layers (like Azure Cache for Redis or Redis Enterprise). Changes: - Add getattr check before accessing connection_pool.disconnect() - Applied to all checkpointer implementations (sync and async) - Added comprehensive tests for the fix Fixes #93
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RedisCluster doesn't have the connection_pool attribute that standard Redis clients have. This causes an AttributeError when using from_conn_string() context managers with Redis deployments that use proxy layers (like Azure Cache for Redis or Redis Enterprise).
Changes:
Fixes #93