Skip to content

Add hybrid search notebook #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 24, 2024
Merged

Add hybrid search notebook #35

merged 8 commits into from
Oct 24, 2024

Conversation

@rbs333
Copy link
Collaborator

@rbs333 rbs333 commented Oct 8, 2024

No description provided.

@tylerhutcherson tylerhutcherson marked this pull request as ready for review October 9, 2024 15:45
@tylerhutcherson tylerhutcherson changed the title hybrid examples Add hybrid search notebook Oct 9, 2024
@tylerhutcherson tylerhutcherson added the enhancement New feature or request label Oct 9, 2024
rbs333
rbs333 commented Oct 15, 2024
View reviewed changes
Copy link
Collaborator Author

@rbs333 rbs333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I think more explanation around the tokenization of the user query would be good

  • we should probably provide a bit more background on aggregation request in general

@justin-cechmanek
Copy link
Contributor

justin-cechmanek commented Oct 18, 2024

The notebook is solid! I agree that a bit more description of what aggregation requests are may help.

justin-cechmanek
justin-cechmanek reviewed Oct 18, 2024
View reviewed changes
@tylerhutcherson tylerhutcherson merged commit 21297c4 into main Oct 24, 2024
1 check passed
@tylerhutcherson tylerhutcherson deleted the feat/RAAE-347/hybrid-examples branch October 24, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justin-cechmanek justin-cechmanek justin-cechmanek approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rbs333 @justin-cechmanek @tylerhutcherson