Skip to content

Fix empty notebook array issue during testing #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Fix empty notebook array issue during testing #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b36de3
fix empty notebook array issue
tylerhutcherson Jan 29, 2025
753e668
try different approach
tylerhutcherson Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/ignore-notebooks.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
doc2cache_llama3_1
semantic_caching_gemini
01_collaborative_filtering
05_nvidia_ai_rag_redis
05_nvidia_ai_rag_redis
13 changes: 10 additions & 3 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,14 +64,21 @@ jobs:
fi

echo "All valid notebooks: $NB_JSON"

# 5) Write to $GITHUB_OUTPUT (modern approach instead of ::set-output)
echo "notebooks=$NB_JSON" >> $GITHUB_OUTPUT

# 5) Write to $GITHUB_OUTPUT
if [ "$NB_JSON" != "[]" ]; then
echo "has_notebooks=true" >> $GITHUB_OUTPUT
else
echo "has_notebooks=false" >> $GITHUB_OUTPUT
fi

echo "notebooks=$NB_JSON" >> $GITHUB_OUTPUT

# ---------------------------------------------------------
# 2) Test each changed notebook in parallel
# ---------------------------------------------------------
test_notebooks:
if: ${{ needs.gather_notebooks.outputs.has_notebooks == 'true' }}
needs: gather_notebooks
runs-on: ubuntu-latest
strategy:
Expand Down