Upgrade to redisvl 0.4.0 #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerhutcherson
requested changes
Feb 24, 2025
Collaborator
tylerhutcherson
left a comment
tylerhutcherson
left a comment
There was a problem hiding this comment.
Nice! a few minor things related to warnings and pinning ragas. but huge effort thank you!
python-recipes/RAG/01_redisvl.ipynb
Outdated
| @@ -270,11 +268,19 @@ | |||
| "outputId": "a8430acc-2e6d-45fd-fc8b-601fbbd8289b" | |||
| }, | |||
| "outputs": [ | |||
| { | |||
| "name": "stderr", | |||
Collaborator
There was a problem hiding this comment.
Hate to do this but I think we should try to ignore these kinds of warnings if possible. Maybe a simple one liner will do it near top of notebook?
| "name": "stderr", | ||
| "output_type": "stream", | ||
| "text": [ | ||
| "huggingface/tokenizers: The current process just got forked, after parallelism has already been used. Disabling parallelism to avoid deadlocks...\n", |
Collaborator
There was a problem hiding this comment.
set the env var here to suppress the warning
| "data": { | ||
| "text/plain": [ | ||
| "\"Nike's revenue for the fiscal year ended May 31, 2023, was $51,217 million, while the revenue for the fiscal year ended May 31, 2022, was $46,710 million. This represents an increase in revenue from the previous year.\"" | ||
| "\"Nike's revenue last year was $44,538 million, and this year it was $51,217 million.\"" |
Collaborator
There was a problem hiding this comment.
interesting it quotes some different numbers
| "execution_count": 1, | ||
| "metadata": {}, | ||
| "outputs": [], | ||
| "outputs": [ |
| } | ||
| ], | ||
| "source": [ | ||
| "%pip install -q redis \"unstructured[pdf]\" sentence-transformers langchain \"langchain-redis>=0.2.0\" langchain-huggingface langchain-openai ragas datasets" |
Collaborator
There was a problem hiding this comment.
probably best to pin ragas given the issues we've had
tylerhutcherson
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.