-
Notifications
You must be signed in to change notification settings - Fork 53
Agent Memory Recipe #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tylerhutcherson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huge effort!
| " }\n", | ||
| "\n", | ||
| " try:\n", | ||
| " long_term_memory_index.load([memory_data])\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you want redisvl to own the creation of the redis key? or do you want the object the be in charge of that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a strong preference generally, but I ran into some confusing behavior queries. Filter queries returned the ID of a document, while vector queries returned the full key as the 'id,' if I recall. Behavior can be more predictable if the application owns keys, but at RedisVL's level of abstraction, having it own the keys makes sense. I tried to let RedisVL handle the keys, I think...
| "\n", | ||
| " if memory_type:\n", | ||
| " if isinstance(memory_type, list):\n", | ||
| " base_filters.append(f\"@memory_type:{{{'|'.join(memory_type)}}}\")\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI with Tag fields you can do == to an Iterable and it will join them ala string with the chosen separator (in the schema)
Tag('memory_type') == [...] for example
definitely interested in expanding the filter notation in redisvl eventually ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, I'll have to explore that a bit more. It seems like I may want to use an OR query sometimes and an AND other times. 🤔 I'll look at Tag syntax closer.
Adds a recipe showing: