Skip to content

Remove limitation blocking autoscaling when multiple databases exist in a subscription #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2025
Merged

Remove limitation blocking autoscaling when multiple databases exist in a subscription #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
426f309
Remove limitation blocking autoscaling when multiple databases exist …
ksampath8 Aug 14, 2025
9c7cbe7
updating docs, fixing tests
slorello89 Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion README.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@ Rule To Scale Redis up 3 GB:
== Limitations

* The Redis Cloud Autoscaler is currently only available for Redis Cloud Pro Subscriptions
* The Redis Cloud Autoscaler will currently only operate on Subscriptions with as single database
* The Redis Cloud Autoscaler will currently only scale a database in (down) deterministically (`Deterministic` is the only valid setting for `DecreaseMemory` and `DecreaseThroughput`)

== Availability
Expand Down
6 changes: 0 additions & 6 deletions ...oud-autoscaler/src/main/java/com/redis/autoscaler/services/RedisCloudDatabaseService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,12 +129,6 @@ public Optional<Task> applyRule(Rule rule) throws IOException, InterruptedExcept

RedisCloudDatabase db = dbOpt.get();

int numDatabases = getDatabaseCount();
if(numDatabases > 1){
LOG.warn("Database count for subscription {} is greater than 1, using autoscaler is not supported, skipping rule: {}", config.getSubscriptionId(), rule);
return Optional.empty();
}


ScaleRequest scaleRequest;
switch (rule.getRuleType()){
Expand Down
6 changes: 1 addition & 5 deletions ...s-cloud-autoscaler/src/test/java/com/redis/autoscaler/RedisCloudDatabaseServiceTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,6 @@ void testScaleDatabaseCRDBMemory() throws Exception {
// Set up the sequence of responses
when(httpClient.send(any(), any()))
.thenReturn(httpResponse) // First call - get database
.thenReturn(countResponse) // Second call - get database count
.thenReturn(scaleResponse); // Third call - scale database

// Execute the rule
Expand Down Expand Up @@ -207,9 +206,8 @@ void testScaleDatabaseCRDBThroughput() throws Exception {
// Set up the sequence of responses
when(httpClient.send(any(), any()))
.thenReturn(httpResponse) // First call - get database
.thenReturn(countResponse) // Second call - get database count
.thenReturn(scaleResponse); // Third call - scale database

// Execute the rule
Optional<Task> taskOpt = service.applyRule(rule);

Expand Down Expand Up @@ -274,7 +272,6 @@ void testRoundUpToNearestTenth() throws Exception {
// Set up the sequence of responses
when(httpClient.send(any(), any()))
.thenReturn(httpResponse) // First call - get database
.thenReturn(countResponse) // Second call - get database count
.thenReturn(scaleResponse); // Third call - scale database

// Execute the rule
Expand Down Expand Up @@ -332,7 +329,6 @@ void testRoundUpToNearest500() {
// Set up the sequence of responses
when(httpClient.send(any(), any()))
.thenReturn(httpResponse) // First call - get database
.thenReturn(countResponse) // Second call - get database count
.thenReturn(scaleResponse); // Third call - scale database

// Execute the rule
Expand Down