Skip to content

Commit ea7b368

Browse files
[fix] Temporary disable oss-cluster spinning on remote runners (#175)
* [fix] Temporary disable oss-cluster spinning on remote runners
1 parent 5278c98 commit ea7b368

File tree

3 files changed

+12
-5
lines changed

3 files changed

+12
-5
lines changed

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[tool.poetry]
22
name = "redisbench-admin"
3-
version = "0.4.2"
3+
version = "0.4.3"
44
description = "Redis benchmark run helper. A wrapper around Redis and Redis Modules benchmark tools ( ftsb_redisearch, memtier_benchmark, redis-benchmark, aibench, etc... )."
55
authors = ["filipecosta90 <[email protected]>"]
66
readme = "README.md"

redisbench_admin/run/cluster.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,6 @@ def spin_up_redis_cluster_remote_redis(
7979
shard_count,
8080
port,
8181
):
82-
raise Exception(
82+
logging.error(
8383
"Remote cluster is still not implemented =(. We're working hard to get it ASAP =)!!"
8484
)

redisbench_admin/run_remote/run_remote.py

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -217,8 +217,13 @@ def run_remote_command_logic(args, project_name, project_version):
217217
)
218218

219219
cluster_api_enabled = False
220+
cluster_start_port = 20000
220221
# setup Redis
221222
if setup_type == "oss-cluster":
223+
logging.error(
224+
"Remote cluster is still not implemented =(. We're working hard to get it ASAP =)!!"
225+
)
226+
continue
222227
cluster_api_enabled = True
223228
spin_up_redis_cluster_remote_redis(
224229
benchmark_config,
@@ -233,19 +238,21 @@ def run_remote_command_logic(args, project_name, project_version):
233238
redis_configuration_parameters,
234239
dbdir_folder,
235240
shard_count,
236-
args.port,
241+
cluster_start_port,
237242
)
238243
dataset_load_start_time = datetime.datetime.now()
239244

240245
# we use node 0 for the checks
241246
local_redis_conn = ssh_tunnel_redisconn(
242-
args.port,
247+
cluster_start_port,
243248
server_private_ip,
244249
server_public_ip,
245250
username,
246251
)
247252
r_conns = []
248-
for p in range(args.port, args.port + shard_count):
253+
for p in range(
254+
cluster_start_port, cluster_start_port + shard_count
255+
):
249256
local_redis_conn, ssh_tunnel = ssh_tunnel_redisconn(
250257
p,
251258
server_private_ip,

0 commit comments

Comments
 (0)