Skip to content

ci: add ruby 3.4 to the matrix #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 28, 2024
Merged

ci: add ruby 3.4 to the matrix #421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee5d467
ci: add ruby 3.4 to the matrix
supercaracal Dec 28, 2024
8f24872
fix
supercaracal Dec 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,11 @@ jobs:
max-parallel: 10
matrix:
include:
- {redis: '7.2', ruby: '3.3'}
- {redis: '7.2', ruby: '3.3', compose: compose.ssl.yaml}
- {redis: '7.2', ruby: '3.3', driver: 'hiredis'}
- {redis: '7.2', ruby: '3.3', driver: 'hiredis', compose: compose.ssl.yaml}
- {redis: '7.2', ruby: '3.3', compose: compose.replica.yaml, replica: '2'}
- {redis: '7.2', ruby: '3.4'}
- {redis: '7.2', ruby: '3.4', compose: compose.ssl.yaml}
- {redis: '7.2', ruby: '3.4', driver: 'hiredis'}
- {redis: '7.2', ruby: '3.4', driver: 'hiredis', compose: compose.ssl.yaml}
- {redis: '7.2', ruby: '3.4', compose: compose.replica.yaml, replica: '2'}
- {task: test_cluster_down}
- {task: test_cluster_broken, restart: 'no', startup: '6'}
- {redis: '8', ruby: '3.3', compose: compose.valkey.yaml, replica: '2'}
Expand Down Expand Up @@ -64,7 +64,7 @@ jobs:
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby || '3.3' }}
ruby-version: ${{ matrix.ruby || '3.4' }}
bundler-cache: true
- name: Pull Docker images
run: docker compose --progress quiet -f $DOCKER_COMPOSE_FILE pull
Expand All @@ -91,7 +91,7 @@ jobs:
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: '3.3'
ruby-version: '3.4'
bundler-cache: true
- name: Get IP address of host
run: |
Expand Down Expand Up @@ -146,7 +146,7 @@ jobs:
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: '3.3'
ruby-version: '3.4'
bundler-cache: true
- name: Run rubocop
run: bundle exec rubocop
Expand All @@ -166,7 +166,7 @@ jobs:
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: '3.3'
ruby-version: '3.4'
bundler-cache: true
- name: Pull Docker images
run: docker compose --progress quiet -f $DOCKER_COMPOSE_FILE pull
Expand Down Expand Up @@ -226,7 +226,7 @@ jobs:
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: '3.3'
ruby-version: '3.4'
bundler-cache: true
- name: Pull Docker images
run: docker compose --progress quiet -f $DOCKER_COMPOSE_FILE pull
Expand Down Expand Up @@ -264,7 +264,7 @@ jobs:
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: '3.3'
ruby-version: '3.4'
bundler-cache: true
- name: Pull Docker images
run: docker compose --progress quiet -f $DOCKER_COMPOSE_FILE pull
Expand Down Expand Up @@ -296,7 +296,7 @@ jobs:
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: '3.3'
ruby-version: '3.4'
bundler-cache: true
- name: Print user limits
run: ulimit -a
Expand Down
3 changes: 2 additions & 1 deletion test/redis_client/test_cluster_config.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
class RedisClient
class TestClusterConfig < TestingWrapper
def test_inspect
want = '#<RedisClient::ClusterConfig [{:host=>"127.0.0.1", :port=>6379}]>'
cfg = { host: '127.0.0.1', port: 6379 }
want = "#<RedisClient::ClusterConfig [#{cfg}]>"
got = ::RedisClient::ClusterConfig.new.inspect
assert_equal(want, got)
end
Expand Down
Loading