Skip to content

fix: wait for threads to be exited on closing workers #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2025
Merged

fix: wait for threads to be exited on closing workers #444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/redis_client/cluster/concurrent_worker/pooled.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,9 @@ def push(task)

def close
@q.clear
@workers.each { |t| t&.exit }
workers = @workers.compact
workers.each(&:exit)
workers.each(&:join)
@workers.clear
@q.close
@pid = nil
Expand Down
6 changes: 5 additions & 1 deletion lib/redis_client/cluster/pub_sub.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,11 @@ def ensure_worker
end

def close
@worker.exit if @worker&.alive?
if @worker&.alive?
@worker.exit
@worker.join
end

@client.close
rescue ::RedisClient::ConnectionError
# ignore
Expand Down
Loading