#RI-4110 - remove dangerous commands recommendation

Author: AmirAllayarovSofteq

redisinsight/api/src/constants/recommendations.ts

@@ -17,12 +17,10 @@ export const RECOMMENDATION_NAMES = Object.freeze({
   REDIS_VERSION: 'redisVersion',
   REDIS_SEARCH: 'redisSearch',
   SEARCH_INDEXES: 'searchIndexes',
-  DANGEROUS_COMMANDS: 'dangerousCommands',
 });
 
 export const ONE_NODE_RECOMMENDATIONS = [
   RECOMMENDATION_NAMES.LUA_SCRIPT,
-  RECOMMENDATION_NAMES.DANGEROUS_COMMANDS,
   RECOMMENDATION_NAMES.AVOID_LOGICAL_DATABASES,
   RECOMMENDATION_NAMES.RTS,
   RECOMMENDATION_NAMES.REDIS_VERSION,

redisinsight/api/src/modules/recommendation/providers/recommendation.provider.spec.ts

@@ -651,18 +651,4 @@ describe('RecommendationProvider', () => {
         expect(redisVersionRecommendation).toEqual(null);
       });
   });
-
-  describe('determineDangerousCommandsRecommendation', () => {
-    it('should not return dangerous commands recommendation when "command" command executed with error',
-      async () => {
-        resetAllWhenMocks();
-        when(nodeClient.sendCommand)
-          .calledWith(jasmine.objectContaining({ name: 'command' }))
-          .mockRejectedValue('some error');
-
-        const dangerousCommandsRecommendation = await service
-          .determineDangerousCommandsRecommendation(nodeClient);
-        expect(dangerousCommandsRecommendation).toEqual(null);
-      });
-  });
 });

redisinsight/api/src/modules/recommendation/providers/recommendation.provider.ts

@@ -438,39 +438,6 @@ export class RecommendationProvider {
     }
   }
 
-  /*
- * Check dangerous commands recommendation
- * @param redisClient
- */
-
-  async determineDangerousCommandsRecommendation(
-    redisClient: Redis | Cluster,
-  ): Promise<Recommendation> {
-    try {
-      const dangerousCommands = await redisClient.sendCommand(
-        new Command('ACL', ['CAT', 'dangerous'], { replyEncoding: 'utf8' }),
-      ) as string[];
-
-      const filteredDangerousCommands = dangerousCommands.filter((command) => {
-        const commandName = command.split('|')[0];
-        return !redisInsightCommands.includes(commandName);
-      });
-
-      const activeDangerousCommands = await Promise.all(
-        filteredDangerousCommands.map(async (command) => await this.checkCommandInfo(redisClient, command)),
-      );
-      const commands = activeDangerousCommands
-        .filter((command) => !isNull(command))
-        .join('\r\n').toUpperCase();
-      return activeDangerousCommands.length
-        ? { name: RECOMMENDATION_NAMES.DANGEROUS_COMMANDS, params: { commands } }
-        : null;
-    } catch (err) {
-      this.logger.error('Can not determine dangerous commands recommendation', err);
-      return null;
-    }
-  }
-
   private async checkAuth(redisClient: Redis | Cluster): Promise<boolean> {
     try {
       await redisClient.sendCommand(
@@ -484,20 +451,6 @@ export class RecommendationProvider {
     return false;
   }
 
-  private async checkCommandInfo(redisClient: Redis | Cluster, command: string): Promise<string> {
-    try {
-      const result = await redisClient.sendCommand(
-        new Command('command', ['info', command]),
-      );
-      if (isNull(result[0])) {
-        return null;
-      }
-    } catch (err) {
-      return null;
-    }
-    return command;
-  }
-
   private checkTimestamp(value: string): boolean {
     try {
       if (!IS_NUMBER_REGEX.test(value) && isValid(new Date(value))) {

redisinsight/api/src/modules/recommendation/recommendation.service.ts

@@ -108,10 +108,6 @@ export class RecommendationService {
         RECOMMENDATION_NAMES.SEARCH_INDEXES,
         async () => await this.recommendationProvider.determineSearchIndexesRecommendation(client, keys, globalClient),
       ],
-      [
-        RECOMMENDATION_NAMES.DANGEROUS_COMMANDS,
-        async () => await this.recommendationProvider.determineDangerousCommandsRecommendation(client),
-      ],
       [
         RECOMMENDATION_NAMES.SET_PASSWORD,
         async () => await this.recommendationProvider.determineSetPasswordRecommendation(client),

redisinsight/ui/src/constants/dbAnalysisRecommendations.json

@@ -687,36 +687,5 @@
       }
     ],
     "badges": ["upgrade"]
-  },
-  "dangerousCommands": {
-    "id": "dangerousCommands",
-    "title": "Rename or disable dangerous commands",
-    "content": [
-      {
-        "id": "1",
-        "type": "paragraph",
-        "value": "The following commands are currently not renamed or disabled for your Instance. These commands are powerful and dangerous if not managed properly. Rename or disable them, especially for the production environment"
-      },
-      {
-        "id": "2",
-        "type": "pre",
-        "parameter": ["commands"],
-        "value": "${0} "
-      },
-      {
-        "id": "3",
-        "type": "spacer",
-        "value": "s"
-      },
-      {
-        "id": "4",
-        "type": "link",
-        "value": {
-          "href": "https://redis.io/docs/management/security/acl/",
-          "name": "Read more"
-        }
-      }
-    ],
-    "badges": ["code_changes"]
   }
 }

redisinsight/ui/src/pages/databaseAnalysis/components/recommendations-view/Recommendations.spec.tsx

@@ -309,20 +309,6 @@ describe('Recommendations', () => {
     expect(screen.queryByTestId('configuration_changes')).not.toBeInTheDocument()
   })
 
-  it('should render configuration_changes badge in dangerousCommands recommendation', () => {
-    (dbAnalysisSelector as jest.Mock).mockImplementation(() => ({
-      ...mockdbAnalysisSelector,
-      data: {
-        recommendations: [{ name: 'dangerousCommands', params: { commands: 'some commands' } }]
-      }
-    }))
-
-    render(<Recommendations />)
-    expect(screen.queryByTestId('code_changes')).toBeInTheDocument()
-    expect(screen.queryByTestId('upgrade')).not.toBeInTheDocument()
-    expect(screen.queryByTestId('configuration_changes')).not.toBeInTheDocument()
-  })
-
   it('should collapse/expand and sent proper telemetry event', () => {
     (dbAnalysisSelector as jest.Mock).mockImplementation(() => ({
       ...mockdbAnalysisSelector,