#RI-5609 - remove functionsWithStreams tip

Author: AmirAllayarovSofteq

redisinsight/api/src/constants/recommendations.ts

@@ -20,7 +20,6 @@ export const RECOMMENDATION_NAMES = Object.freeze({
   STRING_TO_JSON: 'stringToJson',
   SEARCH_VISUALIZATION: 'searchVisualization',
   SEARCH_HASH: 'searchHash',
-  FUNCTIONS_WITH_STREAMS: 'functionsWithStreams',
 });
 
 export const ONE_NODE_RECOMMENDATIONS = [

redisinsight/api/src/modules/browser/keys/keys.service.spec.ts

@@ -196,11 +196,6 @@ describe('KeysService', () => {
         RECOMMENDATION_NAMES.SEARCH_JSON,
         { keys: result, client: mockStandaloneRedisClient, databaseId: mockBrowserClientMetadata.databaseId },
       );
-      expect(recommendationService.check).toBeCalledWith(
-        mockBrowserClientMetadata,
-        RECOMMENDATION_NAMES.FUNCTIONS_WITH_STREAMS,
-        { keys: result, client: mockStandaloneRedisClient, databaseId: mockBrowserClientMetadata.databaseId },
-      );
 
       expect(recommendationService.check).toBeCalledTimes(2);
     });

redisinsight/api/src/modules/browser/keys/keys.service.ts

@@ -109,11 +109,6 @@ export class KeysService {
         RECOMMENDATION_NAMES.SEARCH_JSON,
         { keys: result, client, databaseId: clientMetadata.databaseId },
       );
-      this.recommendationService.check(
-        clientMetadata,
-        RECOMMENDATION_NAMES.FUNCTIONS_WITH_STREAMS,
-        { keys: result, client, databaseId: clientMetadata.databaseId },
-      );
 
       return plainToClass(GetKeyInfoResponse, result);
     } catch (error) {

redisinsight/api/src/modules/database-recommendation/scanner/recommendation.provider.ts

@@ -18,7 +18,6 @@ import {
   BigStringStrategy,
   CompressionForListStrategy,
   BigAmountConnectedClientsStrategy,
-  FunctionsWithStreamsStrategy,
 } from 'src/modules/database-recommendation/scanner/strategies';
 
 @Injectable()
@@ -44,7 +43,6 @@ export class RecommendationProvider {
     this.strategies.set(RECOMMENDATION_NAMES.BIG_STRINGS, new BigStringStrategy());
     this.strategies.set(RECOMMENDATION_NAMES.COMPRESSION_FOR_LIST, new CompressionForListStrategy());
     this.strategies.set(RECOMMENDATION_NAMES.BIG_AMOUNT_OF_CONNECTED_CLIENTS, new BigAmountConnectedClientsStrategy());
-    this.strategies.set(RECOMMENDATION_NAMES.FUNCTIONS_WITH_STREAMS, new FunctionsWithStreamsStrategy(databaseService));
   }
 
   getStrategy(type: string): IRecommendationStrategy {

redisinsight/api/src/modules/database-recommendation/scanner/strategies/functions-with-streams.strategy.spec.ts

@@ -13,4 +13,3 @@ export * from './avoid-lua-scripts.strategy';
 export * from './big-string.strategy';
 export * from './compression-for-list.strategy';
 export * from './big-amount-connected-clients.strategy';
-export * from './functions-with-streams.strategy';

redisinsight/api/src/modules/database-recommendation/scanner/strategies/functions-with-streams.strategy.ts

@@ -671,12 +671,6 @@ describe('RecommendationProvider', () => {
       expect(functionsWithStreamsRecommendation).toEqual(null);
     });
 
-    it('should return functionsWithStreams recommendation when there is stream key', async () => {
-      const functionsWithStreamsRecommendation = await service
-        .determineFunctionsWithStreamsRecommendation([mockStreamKey], mockTfunctionListResponse1);
-      expect(functionsWithStreamsRecommendation).toEqual({ name: RECOMMENDATION_NAMES.FUNCTIONS_WITH_STREAMS });
-    });
-
     it('should return null when there is no stream key', async () => {
       const functionsWithStreamsRecommendation = await service
         .determineFunctionsWithStreamsRecommendation([mockSmallStringKey], mockTfunctionListResponse1);

redisinsight/api/src/modules/database-recommendation/scanner/strategies/index.ts

@@ -544,30 +544,4 @@ export class RecommendationProvider {
       return null;
     }
   }
-
-  /**
-   * Check functionsWithStreams recommendation
-   * @param keys
-   * @param libraries
-   */
-
-  async determineFunctionsWithStreamsRecommendation(
-    keys: Key[],
-    libraries?: string[],
-  ): Promise<Recommendation> {
-    if (libraries?.length) {
-      return null;
-    }
-
-    try {
-      const isStreamKey = keys.some((key) => key.type === RedisDataType.Stream);
-
-      return isStreamKey
-        ? { name: RECOMMENDATION_NAMES.FUNCTIONS_WITH_STREAMS }
-        : null;
-    } catch (err) {
-      this.logger.error('Can not determine functions with streams recommendation', err);
-      return null;
-    }
-  }
 }

redisinsight/api/src/modules/recommendation/providers/recommendation.provider.spec.ts

@@ -116,11 +116,6 @@ export class RecommendationService {
         RECOMMENDATION_NAMES.SEARCH_HASH,
         async () => await this.recommendationProvider.determineSearchHashRecommendation(keys, indexes),
       ],
-      [
-        RECOMMENDATION_NAMES.FUNCTIONS_WITH_STREAMS,
-        async () => await this.recommendationProvider
-          .determineFunctionsWithStreamsRecommendation(keys, libraries),
-      ],
       // it is live time recommendation (will add later)
       [
         RECOMMENDATION_NAMES.STRING_TO_JSON,