-
Notifications
You must be signed in to change notification settings - Fork 387
RI-7294: Fix borders style #4834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RI-7294: Fix borders style #4834
Conversation
Code Coverage - Frontend unit tests
Test suite run success5005 tests passing in 662 suites. Report generated by 🧪jest coverage report action from 2fd69d7 |
height: calc(100% - var(--border-radius-medium)); | ||
width: 100%; | ||
background-color: var(--euiColorEmptyShade); | ||
border: 1px solid var(--euiColorLightShade); | ||
border-radius: var(--border-radius-medium); | ||
// HACK: to fix rectangle like view in rounded borders wrapper | ||
padding-bottom: var(--border-radius-medium); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please avoid adding more debt into the scss files. These colors, spacings, sizings, etc, should be comming from the theme, instead of the eui that we are trying to remove. I've done something similar here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, i did refactor that component to use styled components. So please, take a look.
52b4182
to
2fd69d7
Compare
These fixes are applied for Workbench as well: