Skip to content

RI-7294: Fix borders style #4834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 13, 2025

Conversation

pawelangelow
Copy link
Collaborator

These fixes are applied for Workbench as well:

Screenshot 2025-08-11 at 15 04 27 Screenshot 2025-08-11 at 15 07 27

Copy link
Contributor

github-actions bot commented Aug 11, 2025

Code Coverage - Frontend unit tests

St.
Category Percentage Covered / Total
🟢 Statements 81.71% 19626/24019
🟡 Branches 67.08% 8505/12678
🟡 Functions 75.71% 5199/6867
🟢 Lines 82.14% 19212/23389

Test suite run success

5005 tests passing in 662 suites.

Report generated by 🧪jest coverage report action from 2fd69d7

Comment on lines 3 to 9
height: calc(100% - var(--border-radius-medium));
width: 100%;
background-color: var(--euiColorEmptyShade);
border: 1px solid var(--euiColorLightShade);
border-radius: var(--border-radius-medium);
// HACK: to fix rectangle like view in rounded borders wrapper
padding-bottom: var(--border-radius-medium);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid adding more debt into the scss files. These colors, spacings, sizings, etc, should be comming from the theme, instead of the eui that we are trying to remove. I've done something similar here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, i did refactor that component to use styled components. So please, take a look.

@pawelangelow pawelangelow merged commit cf34065 into feature/RI-6855/vector-search Aug 13, 2025
13 checks passed
@pawelangelow pawelangelow deleted the fe/RI-7294/borders branch August 13, 2025 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants