RI-7303: Store create index command in Search results #4835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelangelow
requested review from
KrumTy,
dantovska,
ArtemHoruzhenko,
pd-redis,
KIvanow and
valkirilov
as code owners
pawelangelow
force-pushed
the
fe/RI-7303/store-command-results-in-proper-place
branch
from
8c8a822 to
2d24dc7
Compare
Code Coverage - Frontend unit tests
Test suite run success5007 tests passing in 662 suites. Report generated by 🧪jest coverage report action from 2111f5f |
KrumTy
reviewed
Aug 13, 2025
Comment on lines
10
to
36
| export const useExecuteQuery = () => { | ||
| return useCallback( | ||
| async ( | ||
| instanceId: string, | ||
| data: string | null | undefined, | ||
| _options?: UseExecuteQueryOptions, | ||
| ) => { | ||
| const options = _options || {} | ||
| if (!data) return [] | ||
|
|
||
| try { | ||
| const result = await executeApiCall( | ||
| instanceId, | ||
| [data], | ||
| RunQueryMode.ASCII, | ||
| ResultsMode.Default, | ||
| ) | ||
| options.afterAll?.() | ||
| return result | ||
| } catch (e) { | ||
| options.onFail?.(e) | ||
| throw e | ||
| } | ||
| }, | ||
| [], | ||
| ) | ||
| } |
There was a problem hiding this comment.
it doesn't make sense for this to be a hook. The callback it returns has no dependencies. Just have a method (executeQuery) instead.
KrumTy
approved these changes
Aug 13, 2025
pawelangelow
deleted the
fe/RI-7303/store-command-results-in-proper-place
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you create a new index, currently, we:
So far, the command that created the index was stored in
Workbenchresults as it reusedWorkbenchaction, but it's better for the UX if the user sees the command in theSearchcommands history.A.k.a. this: