-
Notifications
You must be signed in to change notification settings - Fork 404
[PoC] Namespaces Browser component #5032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,16 @@ | |||
import { NampespacesBrowserTableDataProps } from './types' | |||
|
|||
export const EXAMPLE_DATA: NampespacesBrowserTableDataProps[] = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a very simple interface for the list of namespaces we're going to show. Of course, it can be a subset of a more generic type that will contain more information.
// We can implement customn selection via a radio button | ||
cell: ({ row }) => <RowRadioButton row={row} />, | ||
// Or we can use the built-in checkbox selection | ||
// cell: ({ row }) => <Table.RowSelectionButton row={row} />, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default, Redis UI comes with checkbox row selection, which we can always use if we don't like the "radio" custom implementation.
<FlexGroup direction="column" data-testid="create-index-step2"> | ||
<Col justify="between" gap="xxl"> | ||
<Col gap="xxl"> | ||
<Row justify="between" gap="xxl"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just an example of how the new component can be integrated into the existing "Create Index" flow. This PR is not intended to be merged.
e8f346b
to
9974892
Compare
Description
Created a simple PoC (proof-of-concept) for a Namespaces Browser component that we can use in the upcoming iterations for the Vector Search feature.
This component is based on the
Table
provided by Redis UI (docs), but composed with a bunch of customizations to make it serve the requirements: