fix(ui): add spacing betwen the key details in the header #5037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valkirilov
requested review from
KrumTy,
pawelangelow,
dantovska,
ArtemHoruzhenko and
pd-redis
as code owners
Code Coverage - Frontend unit tests
Test suite run success5162 tests passing in 677 suites. Report generated by 🧪jest coverage report action from b3ce95b |
valkirilov
commented
Oct 6, 2025
| /> | ||
|
|
||
| <EuiFlexItem className={styles.actions}> | ||
| <Spacer size="m" /> |
There was a problem hiding this comment.
Bonus Points: Not related to the changes of the popover colors, but I fixed this minimal spacing issue as well.
| Before | After |
|---|---|
 |
 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added spacing between the key details in the header.
How it was tested
Observe the header with the details about the key (size, ttl, etc.)
Side Quest
Additionally, there was a very odd behavior when you hover over the TTL field and trigger the inline editor. Now, I made some very ugly CSS fixes to make it look like the way before the EUI replacement.
Note: There is a very weird
letter-spacing: -0.12px;and-webkit-font-smoothing: antialiased;applied across the codebase that causes some odd rendering of the font. I didn't touch that, because it looks like a general issue, but we should think about it. Maybe it was a fix related to an old font, but now it makes the current one look blurred.Old
Screen.Recording.2025-10-06.at.16.31.51.mov
Before
Screen.Recording.2025-10-06.at.16.32.23.mov
After
Screen.Recording.2025-10-06.at.16.33.07.mov