Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the allowed_tools definition in the Claude workflow, consolidating it into a single comma-separated string and adding new tool patterns.
- Converted multiline YAML list into a single quoted string
- Introduced new patterns for Python, ruff, uv, pip, pytest, make, etc.
- Removed the original
python -m pytestentry
Comments suppressed due to low confidence (5)
.github/workflows/claude.yml:39
- There are duplicate entries for
Bash(make:*). Please remove one occurrence to avoid redundancy and keep the list clean.
allowed_tools: "Bash,...,Bash(make:*),Bash(pytest:*),..."
.github/workflows/claude.yml:39
- The pattern
Bash(pytest:*)appears twice. Consolidate or remove the duplicate to maintain clarity.
allowed_tools: "Bash,...,Bash(pytest:*),..."
.github/workflows/claude.yml:39
- Hardcoding the full runner workspace path reduces portability. Consider using
${{ github.workspace }}or running commands relative to the default working directory instead.
allowed_tools: "...,Bash(cd /home/runner/work/agent-memory-server/agent-memory-server && ruff check),Bash(cd /home/runner/work/agent-memory-server/agent-memory-server && pytest*)"
.github/workflows/claude.yml:39
- The original
Bash(python -m pytest)entry was removed, which may prevent invoking tests viapython -m pytest. Re-add it or ensure the new patterns cover that common invocation.
allowed_tools: "Bash,Bash(python:*),Bash(ruff:*),..."
.github/workflows/claude.yml:39
- [nitpick] This single-line, comma-separated string is hard to read and maintain. Consider using a YAML list or multiline literal block to improve readability and ease future edits.
allowed_tools: "Bash,Bash(python:*),...View,GlobTool,GrepTool,BatchTool,..."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.