Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR pins Redis to specific versions across tests, scripts, and Docker Compose, updates service ports and adds a new task-worker service, restores Docker Hub publishing in CI, and adjusts TTL handling in the memory server.
- Pinned Redis image to 8.0.3 (tests, scripts, readmes) and redis:8 in root compose
- Changed API service port from 9000 to 9050 and added a
task-workerservice in Docker Compose - Updated agent-memory-server TTL default to
None, added logic for no-TTL storage, bumped versions, and restored Docker Hub push in GitHub Actions
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/docker-compose.yml | Pin test Redis image to 8.0.3 |
| tests/conftest.py | Update REDIS_IMAGE default to redis:8.0.3 |
| manual_oauth_qa/quick_auth0_setup.sh | Pin Docker run to redis:8.0.3 |
| manual_oauth_qa/README.md | Update example Redis run command to redis:8.0.3 |
| examples/travel_agent.py | Adjust import error, logging levels, and prompts |
| examples/memory_prompt_agent.py | Lower logging levels and remove info logs |
| docker-compose.yml | Change service port, add task-worker, pin Redis |
| agent_memory_server/working_memory.py | Allow ttl_seconds=None, branch for no-TTL store |
| agent_memory_server/models.py | Change ttl_seconds field to `int |
| agent_memory_server/mcp.py | Replace SSE implementation with direct Uvicorn run |
| agent_memory_server/init.py | Bump version to 0.9.1 |
| agent-memory-client/models.py | Change client ttl_seconds field to `int |
| agent-memory-client/init.py | Bump client version to 0.9.1 |
| .github/workflows/python-tests.yml | Expand Redis matrix, restore Docker Hub publish |
Comments suppressed due to low confidence (6)
docker-compose.yml:37
- The API service port was updated to 9050 but this change isn't reflected in the project documentation or root README. Consider updating docs to mention the new port for consistency.
- PORT=9050
docker-compose.yml:54
- [nitpick] The
task-workerservice duplicates environment variable blocks from the main service. Using YAML anchors or theextendskey can reduce duplication and ensure settings stay in sync.
task-worker:
agent_memory_server/working_memory.py:124
- New behavior for persistent memories when
ttl_secondsisNoneisn't covered by tests. Please add a test verifying that data stores indefinitely (without TTL) in Redis.
ttl_seconds=working_memory_data.get("ttl_seconds", None),
examples/travel_agent.py:47
- [nitpick] The ImportError is clear, but it could be more actionable by suggesting the install command, e.g.,
pip install langchain-community.
raise ImportError("Please install langchain-community for this demo.") from e
docker-compose.yml:78
- Using
redis:8will pull the latest minor release of the 8.x branch, which can vary between environments. Pinning to an exact version (e.g.,redis:8.0.3) improves reproducibility.
image: redis:8
.github/workflows/python-tests.yml:45
- This change sets
REDIS_IMAGEtoredis:<version>for all matrix entries, but tests relying on Redis Stack features (e.g.,redis-stack-server) may now fail for versions like6.2.6-v9. Consider reintroducing theredis-stack-serverprefix for stack-based versions or adjust tests accordingly.
echo "REDIS_IMAGE=redis:${{ matrix.redis-version }}" >> $GITHUB_ENV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, restore pushing to Docker Hub until our GHCR package is public.