Skip to content

Conversation

@dwdougherty
Copy link
Collaborator

@dwdougherty dwdougherty commented Dec 19, 2024

@dwdougherty dwdougherty requested review from a team and spicy-sauce December 19, 2024 14:52
@dwdougherty dwdougherty self-assigned this Dec 19, 2024
@github-actions
Copy link
Contributor

Copy link
Contributor

@cmilesb cmilesb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@dwdougherty
Copy link
Collaborator Author

Thank you, @cmilesb!

```yaml
source:
table: "*"
row_format: full
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if line 53 will still work if we remove it here, we probably should come up with a better example.
BTW, it also seems that this example is scaffolded in default.yaml.example, not sure if this ideal - @yaronp68

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did what was stated in the JIRA ticket. This will have to sit until @andy-stark-redis is back from PTO.

@dwdougherty dwdougherty deleted the DOC-4682 branch February 25, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants