DEV: add query performance tuning page #1052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-stark-redis
approved these changes
Jan 14, 2025
Contributor
andy-stark-redis
left a comment
andy-stark-redis
left a comment
There was a problem hiding this comment.
Aside from a couple of minor suggestions/questions, LGTM.
Only minor observation is that some of these things might benefit from some explanation as to why they work or else links to other pages that explain them more thoroughly. For example, it would be great to show exactly what goes wrong with the anti-patterns and why the postive patterns avoid those pitfalls.
No need for any of this to be addressed now, of course - might be better handled in a future PR.
content/develop/interact/search-and-query/best-practices/_index.md
Outdated
Show resolved
Hide resolved
content/develop/interact/search-and-query/best-practices/scalable-query-best-practices.md
Outdated
Show resolved
Hide resolved
Co-authored-by: andy-stark-redis <[email protected]>
Collaborator
Author
|
@andy-stark-redis and @joeywhelan, I added some additional text to the anti-patterns section. Please take a look. |
andy-stark-redis
approved these changes
Jan 15, 2025
Contributor
andy-stark-redis
left a comment
andy-stark-redis
left a comment
There was a problem hiding this comment.
Really like the new anti-patterns stuff - very informative :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOC-4716