Skip to content

Update forget docs for ban-list propagation #1057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 15, 2025
Merged

Update forget docs for ban-list propagation #1057

merged 2 commits into from
Jan 15, 2025

Conversation

@nosammai
Copy link
Contributor

@nosammai nosammai commented Jan 15, 2025

Update CLUSTER FORGET docs for changes in redis/redis#10869

@nosammai
Update forget docs for ban-list propagation
484faa6 
Update CLUSTER FORGET docs for changes in redis/redis#10869
@CLAassistant
Copy link

CLAassistant commented Jan 15, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@dwdougherty
Copy link
Collaborator

dwdougherty commented Jan 15, 2025 •
edited
Loading

Hi @nosammai. Thank you for this submission.

Please also add the history front matter to this file on redis/redis. Otherwise, it will be overwritten next time commands.json is merged to this site using our automation.

dwdougherty
dwdougherty requested changes Jan 15, 2025
View reviewed changes
@nosammai
Copy link
Contributor Author

nosammai commented Jan 15, 2025

You also need to add the history front matter to this file on redis/redis. Otherwise, it will be overwritten next time commands.json is merged to this site using our automation.

What branch do I make that change to?

@dwdougherty
Copy link
Collaborator

dwdougherty commented Jan 15, 2025 •
edited
Loading

You also need to add the history front matter to this file on redis/redis. Otherwise, it will be overwritten next time commands.json is merged to this site using our automation.

What branch do I make that change to?

I'm guessing unstable.

@dwdougherty dwdougherty self-assigned this Jan 15, 2025
@nosammai
Copy link
Contributor Author

nosammai commented Jan 15, 2025

Opened redis/redis#13749

dwdougherty
dwdougherty approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@dwdougherty dwdougherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, @nosammai. Approved.

@dwdougherty dwdougherty merged commit 68d8a18 into redis:main Jan 15, 2025
2 checks passed
@nosammai nosammai deleted the patch-1 branch January 15, 2025 18:26
sundb added a commit to redis/redis that referenced this pull request Jan 27, 2025
@nosammai @sundb
Update history for ban-list propagation (#13749)
f5e046a 
Update CLUSTER FORGET docs for changes in
#10869

Docs PR:
redis/docs#1057

---------

Co-authored-by: debing.sun <[email protected]>
@sundb sundb mentioned this pull request Feb 24, 2025
Merged
funny-dog pushed a commit to funny-dog/redis that referenced this pull request Sep 17, 2025
@nosammai @sundb
Update history for ban-list propagation (redis#13749)
e50e678 
Update CLUSTER FORGET docs for changes in
redis#10869

Docs PR:
redis/docs#1057

---------

Co-authored-by: debing.sun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dwdougherty dwdougherty dwdougherty approved these changes

Assignees

@dwdougherty dwdougherty

Labels

dev

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nosammai @CLAassistant @dwdougherty