DOC-4753 added RDI upgrade guide #1089

andy-stark-redis · 2025-01-23T16:44:36Z

DOC-4753 (based on this Confluence page).

Is there any more to add to this before merging? Also, the K8s installation section says that you should download redis-di - can you actually download this separately?

github-actions · 2025-01-23T16:44:52Z

Staging links:
https://redis.io/docs/staging/DOC-4753-rdi-upgrade-guide/integrate/redis-data-integration/installation/
https://redis.io/docs/staging/DOC-4753-rdi-upgrade-guide/integrate/redis-data-integration/installation/upgrade

dwdougherty

Just one minor recommendation. Otherwise, LGTM.

dwdougherty · 2025-01-23T16:54:45Z

content/integrate/redis-data-integration/installation/upgrade.md

+
+### Recovering from failure during a Kubernetes upgrade
+
+If you get an error during the upgrade or some deployments are not OK, then


If OK here is referring to a state shown in a command's output, then using OK is okay. :) Otherwise, use okay. This is not a Google style guide issue per se (it uses both OK and okay to mean the latter), but I've seen this rule on other style guides. Up to you.

@andy-stark-redis maybe we should add:

Run the command sudo k3s kubectl get all -n <namespace> and verify that all the pods are running and that the READY column for all the pods is 1/1. E.g. fornot okstate:

<pod_name> 0/1 CrashLoopBackOff 1881 (91s ago) 6d17h

Done. (I've combined this section with the one above about verifying the installation, btw, since the recovery info is quite short and straightforward.)

galilev · 2025-01-23T17:05:12Z

content/integrate/redis-data-integration/installation/upgrade.md

+
+### Recovering from failure during a VM upgrade
+
+If the previous version is v1.4.4 or later, go to the `rdi_install/<NEW_VERSION>` directory


my mistake, it's not the NEW_VERSION, it's the previous version

content/integrate/redis-data-integration/installation/upgrade.md

galilev · 2025-01-23T17:11:14Z

content/integrate/redis-data-integration/installation/upgrade.md

+    [deploy]({{< relref "/integrate/redis-data-integration/data-pipelines/deploy" >}})
+    again after this step.
+
+1.  Download the latest `redis-di`.


@yaronp68 can we remove it? They don't need it for the k8s installation.

Yes, let's remove it. Also, they cannot just get the latest CLI, it's part of the installation package.

@andy-stark-redis please remove line 109

galilev · 2025-01-23T17:13:04Z

content/integrate/redis-data-integration/installation/upgrade.md

+    docker pull redis/rdi-operator:tagname
+    docker pull redis/rdi-api:tagname
+    docker pull redis/rdi-monitor:tagname
+    docker pull redis/rdi-collector-initializer


@yaronp68 what about the collector-api?

Yes, we should also include it. It will not be an optional component anymore, so let's just add it here.

@galilev , please provide the command so that @andy-stark-redis can add it here.

@andy-stark-redis please add docker pull redis/rdi-collector-api

ZdravkoDonev-redis · 2025-01-30T02:21:43Z

content/integrate/redis-data-integration/installation/_index.md

 - integrate
 - rs
 - rdi
 description: Learn how to install RDI


Suggested change

description: Learn how to install RDI

description: Learn how to install and upgrade RDI

ZdravkoDonev-redis · 2025-01-30T02:24:20Z

content/integrate/redis-data-integration/installation/upgrade.md

+### Recovering from failure during a VM upgrade
+
+If the previous version is v1.4.4 or later, go to the `rdi_install/<NEW_VERSION>` directory
+and run `sudo redis-di upgrade`.


@galilev If the previous version is higher than 1.4.4, shouldn't we be using the upgrade.sh script instead of the CLI?

@ZdravkoDonev-redis yes, I added it to the original document that I sent to @andy-stark-redis - please see https://redislabs.atlassian.net/wiki/spaces/RED/pages/4856348718/Upgrading+RDI+GA+draft#Recovering-from-failure-in-VM-upgrade

ZdravkoDonev-redis · 2025-01-30T02:30:11Z

content/integrate/redis-data-integration/installation/upgrade.md

+
+### Upgrading a VM installation with High availability
+
+If there is an active pipeline, the upgrade process will involve upgrading RDI on the active


@galilev Why upgrading first the active version? Wouldn't you have 2 downtimes this way?

Scenario 1 - upgrade first the active RDI (RDI_instance_1) then the passive RDI (RDI_instance_2):

Upgrade the Active RDI (RDI_instance_1) ---> Downtime, the passive RDI (RDI_instance_2) becomes the active one, since the active is now down

Upgrade the newly active RDI (RDI_instance_2) ---> Downtime, the newly passive RDI (RDI_instance_1) becomes the active one, since the newly active RDI is down

Scenario 2 - upgrade first the passive RDI (RDI_instance_2) then the passive RDI (RDI_instance_1):

Upgrade the passive RDI (RDI_instance_2) ---> no downtime, upgrade succeeds

Upgrade the Active RDI (RDI_instance_1) ---> Downtime, the passive RDI (RDI_instance_2) becomes the active one, since the active is now down

Or am I missing something?

@ZdravkoDonev-redis The upgrade won't trigger a switchover. We plan to upgrade the active RDI first, followed by the passive. @yaronp68 asked whether switching to RDI instance 2 and then upgrading RDI instance 1 would result in zero downtime. However, since a switchover itself requires downtime, this approach wouldn’t be beneficial

DOC-4753 added RDI upgrade guide

e596891

andy-stark-redis added do not merge yet rdi labels Jan 23, 2025

andy-stark-redis requested review from a team and yaronp68 January 23, 2025 16:44

andy-stark-redis self-assigned this Jan 23, 2025

yaronp68 approved these changes Jan 23, 2025

View reviewed changes

dwdougherty approved these changes Jan 23, 2025

View reviewed changes

galilev reviewed Jan 23, 2025

View reviewed changes

content/integrate/redis-data-integration/installation/upgrade.md Show resolved Hide resolved

galilev reviewed Jan 23, 2025

View reviewed changes

ZdravkoDonev-redis reviewed Jan 30, 2025

View reviewed changes

DOC-4753 implemented feedback

4352d97

andy-stark-redis requested review from ZdravkoDonev-redis, dwdougherty, galilev and yaronp68 and removed request for ZdravkoDonev-redis and dwdougherty January 30, 2025 10:36

ZdravkoDonev-redis approved these changes Jan 30, 2025

View reviewed changes

yaronp68 approved these changes Feb 4, 2025

View reviewed changes

andy-stark-redis merged commit 47d101d into main Feb 7, 2025
5 checks passed

andy-stark-redis deleted the DOC-4753-rdi-upgrade-guide branch February 7, 2025 13:28


		### Recovering from failure during a Kubernetes upgrade

		If you get an error during the upgrade or some deployments are not OK, then


		### Recovering from failure during a VM upgrade

		If the previous version is v1.4.4 or later, go to the `rdi_install/<NEW_VERSION>` directory

	description: Learn how to install RDI
	description: Learn how to install and upgrade RDI


		### Upgrading a VM installation with High availability

		If there is an active pipeline, the upgrade process will involve upgrading RDI on the active

DOC-4753 added RDI upgrade guide #1089

DOC-4753 added RDI upgrade guide #1089

Uh oh!

Conversation

andy-stark-redis commented Jan 23, 2025 • edited by atlassian bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 23, 2025

Uh oh!

dwdougherty left a comment

Choose a reason for hiding this comment

Uh oh!

dwdougherty Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

galilev Jan 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

andy-stark-redis Jan 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

galilev Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

galilev Jan 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ZdravkoDonev-redis Jan 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

galilev Jan 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

andy-stark-redis commented Jan 23, 2025 •

edited by atlassian bot

Loading

dwdougherty Jan 23, 2025 •

edited

Loading

galilev Jan 30, 2025 •

edited

Loading

andy-stark-redis Jan 30, 2025 •

edited

Loading

galilev Jan 23, 2025 •

edited

Loading

galilev Jan 30, 2025 •

edited

Loading

ZdravkoDonev-redis Jan 30, 2025 •

edited

Loading

galilev Jan 30, 2025 •

edited

Loading