DOC-4942 ioredis migration docs #1260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dwdougherty
approved these changes
Mar 6, 2025
Collaborator
dwdougherty
left a comment
dwdougherty
left a comment
There was a problem hiding this comment.
Just a few things to consider, but thus far, looks good to me.
| `node-redis` supports only `Promise` objects for results, so | ||
| you must always use a `then()` handler or the | ||
| [`await`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/await) | ||
| operator to receive them. |
Collaborator
There was a problem hiding this comment.
Just wondering if await should be used for examples that return promises. Not a JavaScript guy (but I play one at work), so just thinking out loud.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOC-4942
Currently a work in progress - all suggestions welcome :-)
In particular:
pipeline()and replace them withmulti()...execAsPipeline()).