DOC-4989 added node-js AMR page #1306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dwdougherty
approved these changes
Mar 21, 2025
Collaborator
dwdougherty
left a comment
dwdougherty
left a comment
There was a problem hiding this comment.
Language LGTM. I did not validate the technical details. Just one question about a possibly superfluous asterisk (cheeky bugger). :)
bobymicroby
reviewed
Mar 24, 2025
bobymicroby
reviewed
Mar 24, 2025
| should be refreshed when 75% of its lifetime has elapsed. | ||
| - `retry`: This object specifies the policy to retry refreshing the token if the | ||
| first attempt fails. It has the following fields: | ||
| an error occurs. It has the following fields: |
Member
There was a problem hiding this comment.
we forgot to remove "the" before "an error occurs"
bobymicroby
approved these changes
Mar 24, 2025
Member
bobymicroby
left a comment
bobymicroby
left a comment
There was a problem hiding this comment.
LGTM, one minor typo : we forgot to remove "the" before "an error occurs"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOC-4989
I've worked from the repo README file and also incorporated some stuff from the other clients' AMR pages. Any suggestions or corrections are most welcome :-)