Skip to content

Fix versioned hrefs in docs-nav #1376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2025
Merged

Fix versioned hrefs in docs-nav #1376

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1246618
Fix versioned hrefs in docs-nav
paoloredis Apr 8, 2025
17425d2
Use absURL instead
paoloredis Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions layouts/partials/docs-nav.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{{ define "li" -}}
{{ $page := .page -}}
{{ $pages := .pages -}}
{{ $base := .Site.BaseURL }}
{{ range $pages -}}
{{ $isActive := eq $page . -}}
{{ $isActivePath := $page.IsDescendant . -}}
Expand All @@ -25,9 +24,9 @@
<span class="menu__version-selector__toggler closer version-selector-control">&#x25B2;</span>
</button>
<div id="versionDropdownKubernetes" class="menu__version-selector__list version-selector-control">
<a href="{{ printf "%s%s" $base "operate/kubernetes/" }}" id="kubernetes-version-select-latest" onclick="_setSelectedVersion('kubernetes', 'latest')">latest</a>
<a href="{{ printf "%s%s" $base "operate/kubernetes/7.8.4/" }}" id="kubernetes-version-select-7.8.4" onclick="_setSelectedVersion('kubernetes', 'v7.8.4')">v7.8.4</a>
<a href="{{ printf "%s%s" $base "operate/kubernetes/7.4.6/" }}" id="kubernetes-version-select-7.4.6" onclick="_setSelectedVersion('kubernetes', 'v7.4.6')">v7.4.6</a>
<a href="{{ absURL "operate/kubernetes/" }}" id="kubernetes-version-select-latest" onclick="_setSelectedVersion('kubernetes', 'latest')">latest</a>
<a href="{{ absURL "operate/kubernetes/7.8.4/" }}" id="kubernetes-version-select-7.8.4" onclick="_setSelectedVersion('kubernetes', 'v7.8.4')">v7.8.4</a>
<a href="{{ absURL "operate/kubernetes/7.4.6/" }}" id="kubernetes-version-select-7.4.6" onclick="_setSelectedVersion('kubernetes', 'v7.4.6')">v7.4.6</a>
</div>
</div>
{{else if (eq (.Params.linkTitle) "Redis Software")}}
Expand All @@ -38,8 +37,8 @@
<span class="menu__version-selector__toggler closer version-selector-control">&#x25B2;</span>
</button>
<div id="versionDropdownRs" class="menu__version-selector__list version-selector-control">
<a href="{{ printf "%s%s" $base "operate/rs/" }}" id="rs-version-select-latest" onclick="_setSelectedVersion('rs', 'latest')">latest</a>
<a href="{{ printf "%s%s" $base "operate/rs/7.4/" }}" id="rs-version-select-7.4" onclick="_setSelectedVersion('rs', 'v7.4')">v7.4</a>
<a href="{{ absURL "operate/rs/" }}" id="rs-version-select-latest" onclick="_setSelectedVersion('rs', 'latest')">latest</a>
<a href="{{ absURL "operate/rs/7.4/" }}" id="rs-version-select-7.4" onclick="_setSelectedVersion('rs', 'v7.4')">v7.4</a>
</div>
</div>
</li>
Expand Down